Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failed getting entity with fetch eager property #11090

Merged
merged 5 commits into from
Mar 16, 2024
Merged

Failed getting entity with fetch eager property #11090

merged 5 commits into from
Mar 16, 2024

Conversation

dbannik
Copy link
Contributor

@dbannik dbannik commented Nov 28, 2023 •
edited
Loading

Here, I provided tests for reproduction but without the solution to the problem itself.

Diff WithoutFetchEager\AbstractRemoveControl and WithFetchEager\AbstractRemoveControl
image

@dbannik dbannik mentioned this pull request Nov 28, 2023
Closed
@dbannik dbannik force-pushed the 2.17.x-failed-getting-entity-with-fetch-eager branch 2 times, most recently from a34f0d7 to 5bf5c5a Compare November 28, 2023 21:12
@dbannik dbannik marked this pull request as ready for review December 1, 2023 01:33
dbannik added a commit to dbannik/orm that referenced this pull request Feb 13, 2024
@dbannik
doctrine#11090 - Fix obtaining an identifier in cases where the hydra…
9a20452 
…tion has not yet fully completed on eagerLoadCollections
@dbannik dbannik force-pushed the 2.17.x-failed-getting-entity-with-fetch-eager branch from 39ea503 to 9a20452 Compare February 13, 2024 11:15
@dbannik
Copy link
Contributor Author

dbannik commented Feb 13, 2024

test passed. please check my fix

@dbannik dbannik changed the base branch from 2.17.x to 2.18.x February 15, 2024 10:08
dbannik added a commit to dbannik/orm that referenced this pull request Feb 15, 2024
@dbannik
doctrine#11090 - Fix obtaining an identifier in cases where the hydra…
c586e4b 
…tion has not yet fully completed on eagerLoadCollections
@dbannik dbannik mentioned this pull request Feb 15, 2024
Closed
@dbannik dbannik changed the base branch from 2.18.x to 2.17.x February 15, 2024 10:13
@dbannik
doctrine#11090 - Fix obtaining an identifier in cases where the hydra…
e5e3166 
…tion has not yet fully completed on eagerLoadCollections
@greg0ire greg0ire changed the base branch from 2.17.x to 2.18.x February 16, 2024 10:18
@greg0ire greg0ire force-pushed the 2.17.x-failed-getting-entity-with-fetch-eager branch from 9a20452 to e5e3166 Compare February 16, 2024 10:21
beberlei
beberlei previously approved these changes Mar 16, 2024
View reviewed changes
Copy link
Member

@beberlei beberlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't think about this case when working on #8391

The test and fix are valid.

I cleaned it up a little.

@greg0ire greg0ire changed the base branch from 2.18.x to 2.19.x March 16, 2024 20:04
@greg0ire greg0ire dismissed beberlei’s stale review March 16, 2024 20:04

The base branch was changed.

@greg0ire greg0ire added Bug and removed Failing Test labels Mar 16, 2024
@greg0ire greg0ire added this to the 2.19.1 milestone Mar 16, 2024
@greg0ire greg0ire merged commit abcad6f into doctrine:2.19.x Mar 16, 2024
58 checks passed
@greg0ire
Copy link
Member

Thanks @dbannik and @beberlei !

@github-actions github-actions bot mentioned this pull request Mar 16, 2024
Merged
@derrabus derrabus changed the title [2.17.x] Failed getting entity with fetch eager property Failed getting entity with fetch eager property Mar 16, 2024
@sakalys sakalys mentioned this pull request Aug 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg0ire greg0ire greg0ire approved these changes

@beberlei beberlei beberlei left review comments

Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
2.19.1
Development

Successfully merging this pull request may close these issues.
3 participants
@dbannik @greg0ire @beberlei