This repository has been archived by the owner on Nov 11, 2020. It is now read-only.
Improve events/logging for Database methods #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pre-event was being dispatched twice. Also renamed the doGetGridFS() method to be consistent.
PHPUnit doesn't seem to care about this, but this is more accurate.
This corrects an invalid variable reference and adds a test for the method. Additionally, the handling for multiple driver APIs is moved to a "do" method. Also, use doSelectCollection() to avoid dispatching extra events.
LoggableDatabase must support the same arguments as the base method, which means duplicate the logic. Ensure the created collection's name is logged, as well as the new options array. Deprecate the older log format (akin to what was done in CreateCollectionEventArgs).
jmikola
added a commit
that referenced
this pull request
Aug 12, 2013
Improve events/logging for Database methods
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
getGridFS()andcreateCollection()createCollection()and make LoggableDatabase's API consistent with the base class