This repository has been archived by the owner on Nov 11, 2020. It is now read-only.
Internal cursor improvements for hint, sort, RP and recreation #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
added a commit
to doctrine/mongodb-odm
that referenced
this pull request
Apr 22, 2013
This depends on doctrine/mongodb#105 being merged into a stable 1.1.x release of doctrine/mongodb.
5 tasks
|
@jwage: This is based on what we discussed in IRC last week. Please give it a once-over when you get a chance. I'd like to move onto supporting read preferences in the query builder after this, and then resolve the referenced ODM PR. |
Successive calls to MongoCursor::hint() or sort() will overwrite the previous value, so there is no reason to store multiple values in the Doctrine class. ODM does seem to depend on the hints property to track UnitOfWork hints (entirely different than MongoDB index usage hints), but that should be changed upstream.
Change the return value for setReadPreference() so it can be chained with other methods. The boolean return code from the MongoCursor method will be checked and used to throw an exception if necessary. Save the current read preference and tags on Cursor, so it can be recreated (as is done for slaveOkay).
|
👍 |
jmikola
added a commit
that referenced
this pull request
Apr 23, 2013
Internal cursor improvements for hint, sort, RP and recreation
jmikola
added a commit
to doctrine/mongodb-odm
that referenced
this pull request
Jun 4, 2013
This depends on doctrine/mongodb#105 being merged into a stable 1.1.x release of doctrine/mongodb.
jmikola
added a commit
to doctrine/mongodb-odm
that referenced
this pull request
Nov 1, 2013
This depends on doctrine/mongodb#105 being merged into a stable 1.1.x release of doctrine/mongodb.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few changes here:
hint()andsort(). ODM does seem to use$hintsto store it's own refresh/slaveOkay hints, but that should be changed upstream. ODM currently requiresdoctrine/mongodb1.0.*, and this would be merged to1.1.x, so I don't see a problem.recreate(), which should help with Paginator adapter ignore sorting DoctrineMongoODMModule#70.setReadPreference()by making it chainable, able to throw an exception if the driver method fails, and integrating it withrecreate().