Use symfony/deprecation-contracts to announce deprecations in code #2249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SenseException
requested changes
Nov 26, 2020
SenseException
approved these changes
Nov 26, 2020
Co-authored-by: Claudio Zizza <[email protected]>
Co-authored-by: Claudio Zizza <[email protected]>
alcaeus
force-pushed
the
deprecation-contracts
branch
from
c203c14 to
dd8fb01
Compare
malarzm
reviewed
Dec 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This replaces manual calls to
@trigger_errorwithtrigger_deprecationfrom thesymfony/deprecation-contractspackage. This allows users to override thetrigger_deprecationfunction to implement their custom logic.Note that this PR drops deprecation functionality for field mapping annotations that were supposed to be dropped in 2.0. Since these methods are marked
@internal, I have no problem dropping them in a minor release.