Skip to content

Commit

Permalink
Drop support for PHP < 7.2
Browse files Browse the repository at this point in the history
  • Loading branch information
@alcaeus
alcaeus committed Jun 8, 2019
1 parent 1febd6c commit 5576f70
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion composer.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
{"name": "Johannes Schmitt", "email": "[email protected]"}
],
"require": {
"php": ">=5.3.2"
"php": "^7.2"
},
"require-dev": {
"phpunit/phpunit": "^4.5"
Expand Down

7 comments on commit 5576f70

@pribeirojtm
Copy link

@pribeirojtm pribeirojtm commented on 5576f70 Jun 11, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello. I'm using the latest tag of sf 3.4, "doctrine/doctrine-bundle": "^1.10", and "doctrine/orm": "^2.5".
I'm on these versions of doctrine due fact of php still in version 7.0.* in our server
Doing composer outdated, it shows me this package, that could be possible updated from v1.0.1 to v1.0.2.
My question is,will I have problems updating this package to newest version since it only requires php version superior to 7.2?
Thanks.

@xabbuh
Copy link
Member

@xabbuh xabbuh commented on 5576f70 Jun 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit wasn't part of the 1.0.2 release.

@pribeirojtm
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xabbuh , sorry, I didn't understand.

@alcaeus
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The upcoming 1.1.0 release will drop support for PHP < 7.2, but the newly released 1.0.2 version still does. When it’s time to upgrade to 1.1.0, composer will figure out whether that version is eligible (e.g. if you’re running composer update on PHP 7.2 or newer). We’ve explained this a while back in our blog: https://www.doctrine-project.org/2017/07/25/php-7.1-requirement-and-composer.html

@pribeirojtm
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alcaeus , thanks. So as I understand, and from your link, even if I update this package, I won't have any problems even running with php 7.0, right? I've run composer update and it let update the package on my dev machine. My thing is that if I will have any surprise when using the application. For now, I'm not having any issue..

@alcaeus
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are running 7.0 on your dev machine or have the correct platform config in composer.json, everything will work as expected. If you run 7.2 locally and try to deploy to 7.0, don’t.

@pribeirojtm
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alcaeus. Yes, indeed I'm running 7.0.* on dev and in prod env. Even package was updated, it seems is not using >= 7.3 code

Please sign in to comment.