Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the state resetting between tests #56

Merged
merged 1 commit into from
Jun 3, 2023
Merged

Fix the state resetting between tests #56

merged 1 commit into from
Jun 3, 2023

Conversation

stof
Copy link
Member

@stof stof commented Jun 2, 2023

The old logic was missing part of the state:

  • it was not resetting the enabled types in the mask
  • it was not resetting the new ignoredLinks property

@stof stof added the test suite Improvements to the test suite label Jun 2, 2023
@stof stof added this to the v1.1.1 milestone Jun 2, 2023
@stof
Fix the state resetting between tests
f6f2c45 
The old logic was missing part of the state:

- it was not resetting the enabled types in the mask
- it was not resetting the new ignoredLinks property
@stof stof force-pushed the fix_state_reset branch from 08c6733 to f6f2c45 Compare June 2, 2023 22:36
@greg0ire greg0ire merged commit 612a3ee into doctrine:1.1.x Jun 3, 2023
@greg0ire greg0ire mentioned this pull request Jun 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg0ire greg0ire greg0ire approved these changes

Assignees
No one assigned
Labels
test suite Improvements to the test suite
Projects
None yet
Milestone
v1.1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@stof @greg0ire