Improve static analysis #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The returned mock is both a MockObject and a LoggerInterface. Due to the min PHP version, we cannot use an intersection type. However, the caller only cares about the LoggerInterface currently as the mock is entirely configured in this method.
This field does not contain one of the type constants. It is actually an int-mask of them.
greg0ire
force-pushed
the
better_sa_config
branch
from
bb52505 to
f23167a
Compare
|
@stof I fixed the cs job |
greg0ire
approved these changes
Jun 2, 2023
greg0ire
added
Static Analysis
and removed
CI
|
Created a new "Static Analysis" label as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps phpstan to level 6 (from level 3) and psalm to level 4 (from level 7) by fixing the few issues (I actually worked on improving the phpstan level and then looked for the new psalm level that reports no errors for this PR).
Relates to #46