Fix Deprecation::ignoreDeprecations #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
reviewed
Jun 2, 2023
greg0ire
approved these changes
Jun 2, 2023
stof
reviewed
Jun 2, 2023
ruudk
force-pushed
the
fix
branch
2 times, most recently
from
1c2552e to
680091a
Compare
stof
reviewed
Jun 2, 2023
Turns out that `Deprecation::ignoreDeprecations` does not work at all.
stof
approved these changes
Jun 2, 2023
|
Thanks @ruudk ! |
|
Would it be possible to tag this? So that I can stop some deprecations on production? 😅 |
|
Sure thing. Out of interest, how urgent is it for you and why? |
|
Thanks for the tag! It was producing a 10-20 deprecations an hour. Great to be able to stop this 😃 |
|
Ok, so definitely not a money problem then I trust, just an output clutter issue? Cc @mpdude, I think this topic will interest you, w.r.t doctrine/doctrine-website#485 |
|
Deployed 1.1.1 and the deprecations stopped. Great 💙 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies @greg0ire's feedback and fixes #31