Optimize introspection of table comments on PostgreSQL #5449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morozov
force-pushed
the
pgsql-table-options
branch
from
96e8efc to
bd983fb
Compare
greg0ire
reviewed
Jun 18, 2022
Comment on lines
+729
to
+730
| * @param string|null $tableName | ||
| * |
There was a problem hiding this comment.
Suggested change
| * @param string|null $tableName | |
| * |
| */ | ||
| private function getTableWhereClause($table, $classAlias = 'c', $namespaceAlias = 'n'): string | ||
| private function buildQueryConditions($tableName): array |
There was a problem hiding this comment.
Suggested change
| private function buildQueryConditions($tableName): array | |
| private function buildQueryConditions(?string $tableName): array |
There was a problem hiding this comment.
You're right. We don't have strict types enabled here, so even given that the public methods that call this one don't enforce the type of $tableName, we can rely on implicit casting here.
But this is non-essential and is hard to reason about since these requirements aren't enforced by the code style or static analysis. We do want to enforce parameter types on all new APIs but it's not a public API.
This change will be consistently implemented during the merge up to 4.0.x.
greg0ire
approved these changes
Jun 19, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of
PostgreSQLSchemaManager::fetchTableOptionsByTable()fetches the comment of each table individually although the API introduced in #5268 enables fetching schema metadata in a fixed number of queries.Additionally, some cleanup is done in the codebase.