Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and improve docs #4260

Merged
merged 1 commit into from
Dec 7, 2020
Merged

Fix and improve docs #4260

merged 1 commit into from
Dec 7, 2020

Conversation

greeflas
Copy link
Contributor

@greeflas greeflas commented Sep 7, 2020

Q A
Type improvement
BC Break no
Fixed issues -

Summary

I just fixed and improved some docs.

SenseException
SenseException requested changes Sep 8, 2020
View reviewed changes
Copy link
Member

@SenseException SenseException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catches and fixes 👍

docs/en/reference/supporting-other-databases.rst Outdated Show resolved Hide resolved
docs/en/reference/caching.rst Outdated Show resolved Hide resolved
greg0ire
greg0ire previously approved these changes Sep 8, 2020
View reviewed changes
SenseException
SenseException previously approved these changes Sep 8, 2020
View reviewed changes
morozov
morozov requested changes Sep 12, 2020
View reviewed changes
docs/en/reference/platforms.rst Outdated Show resolved Hide resolved
docs/en/reference/sharding_azure_tutorial.rst Outdated Show resolved Hide resolved
docs/en/reference/supporting-other-databases.rst Outdated Show resolved Hide resolved
docs/en/reference/supporting-other-databases.rst Outdated Show resolved Hide resolved
@morozov
Copy link
Member

morozov commented Sep 12, 2020

Please rebase to fix the PostgreSQL failures.

@greeflas greeflas dismissed stale reviews from SenseException and greg0ire via 3752149 September 30, 2020 20:35
@morozov morozov changed the base branch from 2.10.x to 2.12.x November 29, 2020 21:35
@morozov morozov added this to the 2.12.2 milestone Dec 7, 2020
@morozov morozov merged commit 373c24d into doctrine:2.12.x Dec 7, 2020
@morozov
Copy link
Member

morozov commented Dec 7, 2020

Thanks, @greeflas.

@morozov morozov modified the milestones: 2.12.2, 2.13.0 Apr 8, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SenseException SenseException SenseException left review comments

@morozov morozov morozov approved these changes

@greg0ire greg0ire greg0ire left review comments

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
2.13.0
Development

Successfully merging this pull request may close these issues.
4 participants
@greeflas @morozov @greg0ire @SenseException