Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Utilizing Expression::visit method instead of switch-case #230

Open
wants to merge 2 commits into
base: 2.0.x
Choose a base branch
from
+1 −11
Open

Utilizing Expression::visit method instead of switch-case #230

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4032a1f
Utilizing Expression::visit method instead of switch-case in Expressi…
oleg-andreyev Mar 5, 2020
a7ddf88
!squash removed get_class import
oleg-andreyev Mar 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions lib/Doctrine/Common/Collections/Expr/ExpressionVisitor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
namespace Doctrine\Common\Collections\Expr;

use RuntimeException;
use function get_class;

/**
* An Expression visitor walks a graph of expressions and turns them into a
Expand Down Expand Up @@ -43,15 +42,6 @@ abstract public function walkCompositeExpression(CompositeExpression $expr);
*/
public function dispatch(Expression $expr)
{
switch (true) {
case $expr instanceof Comparison:
return $this->walkComparison($expr);
case $expr instanceof Value:
return $this->walkValue($expr);
case $expr instanceof CompositeExpression:
return $this->walkCompositeExpression($expr);
default:
throw new RuntimeException('Unknown Expression ' . get_class($expr));
}
return $expr->visit($this);
}
}