Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate fixture_loader option #790

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

franmomu
Copy link
Contributor

@franmomu franmomu commented Nov 2, 2023

ContainerAwareLoader class is deprecated in Symfony 6.4 (and removed in 7.0) and looking at the usages I bumped into fixture_loader option.

This option was introduced long time ago in 5a1208c and it was used to instantiate that fixture loader in LoadDataFixturesDoctrineODMCommand.

Right now this option apparently is only used to set this parameter:

// set the fixtures loader
$container->setParameter('doctrine_mongodb.odm.fixture_loader', $config['fixture_loader']);

But we don't use this parameter since 3.6 in #529 (correction: in 3.6 was still used but in a deprecated path that was removed in 4.0)

I decided to apart from deprecating the option, to remove the parameter (I can re-add it) which I guess/hope no one is using it (they shouldn't).

@franmomu franmomu added this to the 4.7.0 milestone Nov 2, 2023
Copy link
Member

@malarzm malarzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess/hope no one is using it (they shouldn't).

Let's add our reasoning to UPDATE-4.7md file and I'm willing to take a chance on removing this now 👍

@malarzm malarzm merged commit 2a43549 into doctrine:4.7.x Nov 23, 2023
16 checks passed
@malarzm
Copy link
Member

malarzm commented Nov 23, 2023

Thanks @franmomu!

@franmomu franmomu deleted the deprecate_fixture_loader branch November 25, 2023 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants