Fix mkdir() race condition #745
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicit allow for composer plugins
|
@andrey-tech thanks for the PR! Would you mind rebasing your branch? I've merged #746 to fix CI issues. |
|
@andrey-tech mind running |
|
Gonna merge this in #747 with your commit preserved. Thanks @andrey-tech! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
mkdir() race condition in cache warmers.
The race condition is appears when several processes are attempting to create a same Doctrine Proxy/Hydrator directory which does not yet exist and
\RuntimeExceptionis thrown.This PR adds an extra check
!is_dir().