Add support for PHP 8 #662
Conversation
|
waiting for merge of PR doctrine/mongodb-odm#2248 |
|
This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions. |
|
So there has been a release: https://github.com/doctrine/mongodb-odm/releases/tag/2.2.0 😬 |
|
Just in case, I created yesterday #666. |
|
I have this error in phpunit for PHP 8. In PHP 8, This error is raised on code coverage. |
| @@ -17,5 +17,6 @@ public function testCollector() | |||
| $collector = new CommandDataCollector(new CommandLogger()); | |||
|
|
|||
| $collector->collect($request = new Request(['group' => '0']), $response = new Response()); | |||
| $this->assertSame(0, $collector->getCommandCount()); | |||
There was a problem hiding this comment.
test was marked as risky. so I've added at least one assert.
| @@ -35,18 +35,12 @@ class Guesser | |||
| /** @ODM\Field(type="bool") */ | |||
| public $boolField; | |||
|
|
|||
| /** @ODM\Field(type="boolean") */ | |||
There was a problem hiding this comment.
I had this error in phpunit
Remaining indirect deprecation notices (2)
1x: Since doctrine/mongodb-odm 2.1: The "boolean" mapping type is deprecated. Use "bool" instead.
1x in TypeGuesserTest::testTypesShouldBeGuessedCorrectly from Doctrine\Bundle\MongoDBBundle\Tests\Form\Type
1x: Since doctrine/mongodb-odm 2.1: The "integer" mapping type is deprecated. Use "int" instead.
1x in TypeGuesserTest::testTypesShouldBeGuessedCorrectly from Doctrine\Bundle\MongoDBBundle\Tests\Form\Type
There was a problem hiding this comment.
It'd be the best to extract these two asserts into a separate test that would allow deprecation notices but considering simplicity of the guesser I think we'll be just fine
|
Thanks a lot @lepiaf! |
No description provided.