Improve collector view #652

Jean-Beru · 2020-10-02T13:43:29Z

This PR makes the collector show execution time of commands. Style has been taken from DoctrineBundle and could be improved in future PR (eg: a better command display).

We may add a better command display later. Eg: db.User.find({ _id: 1 });.

Resources/views/Collector/mongodb.html.twig

DataCollector/CommandDataCollector.php

stale · 2020-12-11T08:11:26Z

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

Jean-Beru · 2020-12-11T22:53:57Z

Is there anything that I can do to make this PR OK ?

alcaeus · 2020-12-12T08:52:17Z

I don't have enough time to review things at the moment, so there isn't much you can do. I'll mark this so the bot doesn't keep reminding you that I don't have time 😞

Jean-Beru · 2020-12-12T14:14:00Z

I totally understand. I thought that you were waiting for some changes. Good luck and happy holiday season 😉

IonBazan

@alcaeus This feature would quite useful to many people. I was actually starting working on something similar but then found this PR. Is there any chance you could find a moment to take a look on that again? 🙏🏻

DataCollector/CommandDataCollector.php

Resources/views/Collector/mongodb.html.twig

noniagriconomie · 2021-06-11T13:39:55Z

May I ask you some screenshots? I would definitly love to have this improved UI as well, thanks :)

Jean-Beru · 2021-06-11T14:01:16Z

Of course, I have just updated PR's description.

composer.json

IonBazan

✨

alcaeus

LGTM with the email change reverted 😊

composer.json

IonBazan · 2021-07-25T07:53:49Z

Resources/views/Collector/mongodb.html.twig

+                <td class="nowrap">{{ loop.index }}</td>
+                <td class="nowrap">{{ '%0.3f'|format(command.durationMicros / 1000) }} ms</td>
+                <td class="nowrap">{{ command.database }}</td>
+                <td>{{ command.command }}</td>


Raw JSONs are hard to read so I think we could add a collapsible pretty-print version of the command JSON here just like in ElasticaBundle: https://github.com/FriendsOfSymfony/FOSElasticaBundle/blob/master/src/Resources/views/Collector/elastica.html.twig#L129-L135

What about decoding and encoding current value in template to keep canonical extended JSON format ? Like {{ data|json_decode|json_encode(constant('JSON_PRETTY_PRINT')) }}.

Yes, that makes sense 👍🏻

Done. FYI, json_decode has been done in DataCollector since Twig does not provide a such filter, cf. twigphp/Twig#824.

IonBazan · 2021-07-26T16:30:51Z

Resources/views/Collector/mongodb.html.twig

@@ -68,7 +68,9 @@
                <td class="nowrap">{{ loop.index }}</td>
                <td class="nowrap">{{ '%0.3f'|format(command.durationMicros / 1000) }} ms</td>
                <td class="nowrap">{{ command.database }}</td>
-                <td>{{ command.command }}</td>
+                <td>
+                    <pre>{{ command.command|json_encode(constant('JSON_PRETTY_PRINT')) }}</pre>


I think we should show the non-pretty-print one first and allow to expand it for the pretty print one. You can use data-toggle-selector attributes to achieve it. See https://github.com/doctrine/DoctrineBundle/blob/2.4.x/Resources/views/Collector/db.html.twig

Done by using existing queries-table and sql-runnable CSS classes.

Jean-Beru · 2021-07-28T18:12:00Z

The CI failed :

==> Setup Extensions
✗ mongodb-1.10.12 Could not install mongodb-1.10.12 on PHP 7.2.34
Error: The process '/usr/bin/bash' failed with exit code 1

Is it due to ext-mongodb in composer.json ? 🤔

alcaeus · 2021-07-29T06:47:29Z

I'll have to investigate what's going on here: 1.10.12 does not exist, and the build specifically calls for installing 1.5.0. For some reason, the version matches what we had above for pecl, so I'm inclined to think there's a separate issue going on. I'll take a look.

alcaeus · 2021-08-11T07:12:01Z

I've updated the target branch to 4.4.x and rebased, which of course adds psalm errors. @franmomu would you be able to add the array shapes to this so we can wrap it up? Thanks!

franmomu · 2021-08-11T07:30:56Z

There you go!

alcaeus · 2021-08-11T07:32:42Z

You're a legend, @franmomu! Thanks @Jean-Beru and @IonBazan for getting this one done! 🎉

alcaeus reviewed Oct 2, 2020

View reviewed changes

Resources/views/Collector/mongodb.html.twig Outdated Show resolved Hide resolved

Resources/views/Collector/mongodb.html.twig Outdated Show resolved Hide resolved

Resources/views/Collector/mongodb.html.twig Outdated Show resolved Hide resolved

alcaeus reviewed Oct 8, 2020

View reviewed changes

DataCollector/CommandDataCollector.php Outdated Show resolved Hide resolved

Jean-Beru force-pushed the feature/improve-collector-view branch from 87bd733 to 6e0bc70 Compare October 17, 2020 12:40

stale bot added Stale Issues that have not seen any activity in 30 days and removed Stale Issues that have not seen any activity in 30 days labels Dec 11, 2020

IonBazan reviewed Jun 10, 2021

View reviewed changes

DataCollector/CommandDataCollector.php Outdated Show resolved Hide resolved

Resources/views/Collector/mongodb.html.twig Show resolved Hide resolved

Jean-Beru force-pushed the feature/improve-collector-view branch from 99c7508 to 6874044 Compare June 11, 2021 13:10

IonBazan reviewed Jul 1, 2021

View reviewed changes

composer.json Outdated Show resolved Hide resolved

noniagriconomie approved these changes Jul 13, 2021

View reviewed changes

IonBazan approved these changes Jul 21, 2021

View reviewed changes

alcaeus reviewed Jul 22, 2021

View reviewed changes

composer.json Outdated Show resolved Hide resolved

alcaeus approved these changes Jul 22, 2021

View reviewed changes

IonBazan reviewed Jul 25, 2021

View reviewed changes

IonBazan reviewed Jul 26, 2021

View reviewed changes

alcaeus added the Enhancement label Aug 11, 2021

alcaeus added this to the 4.4.0 milestone Aug 11, 2021

alcaeus changed the base branch from 4.3.x to 4.4.x August 11, 2021 06:57

alcaeus self-assigned this Aug 11, 2021

noniagriconomie and others added 3 commits August 11, 2021 09:04

Update link following documentation revamp (doctrine#670)

d709286

Update first_steps.rst

20998a0

Improve collector view

d2728a2

Jean-Beru added 14 commits August 11, 2021 09:04

Fix CS and review

e0ce127

Add tests

ac8cd50

Fix display

492bdfb

Add database name

c05af35

Update tests

97b3078

Display canonical extended JSON

ea49919

CS

e7ac9c4

Add ext-mongodb dependency

1e7060b

Set ext-mongodb to ^1.5

a62b573

Fix CS

7277b7d

Fix typo

4d44c53

Fix Tests

c5356f8

Update display

dd3bee8

Display formatted command on demand

9bec393

alcaeus force-pushed the feature/improve-collector-view branch from bfb536b to 9bec393 Compare August 11, 2021 07:10

Add array-shape for CommandDataCollector::getCommands

ba53845

franmomu approved these changes Aug 11, 2021

View reviewed changes

alcaeus merged commit cfa2ec4 into doctrine:4.4.x Aug 11, 2021

IonBazan linked an issue Sep 20, 2021 that may be closed by this pull request

Show query time in profiler #319

Closed

This was referenced Sep 20, 2021

Show query time in profiler #319

Closed

Profiler log output should use strict JSON representation for BSON types #178

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve collector view #652

Improve collector view #652

Jean-Beru commented Oct 2, 2020 •

edited

Loading

stale bot commented Dec 11, 2020

Jean-Beru commented Dec 11, 2020

alcaeus commented Dec 12, 2020

Jean-Beru commented Dec 12, 2020

IonBazan left a comment •

edited

Loading

noniagriconomie commented Jun 11, 2021

Jean-Beru commented Jun 11, 2021

IonBazan left a comment

alcaeus left a comment

IonBazan Jul 25, 2021

Jean-Beru Jul 26, 2021

IonBazan Jul 26, 2021

Jean-Beru Jul 26, 2021

IonBazan Jul 26, 2021

Jean-Beru Jul 27, 2021

Jean-Beru commented Jul 28, 2021

alcaeus commented Jul 29, 2021

alcaeus commented Aug 11, 2021

franmomu commented Aug 11, 2021

alcaeus commented Aug 11, 2021

Improve collector view #652

Improve collector view #652

Conversation

Jean-Beru commented Oct 2, 2020 • edited Loading

stale bot commented Dec 11, 2020

Jean-Beru commented Dec 11, 2020

alcaeus commented Dec 12, 2020

Jean-Beru commented Dec 12, 2020

IonBazan left a comment • edited Loading

Choose a reason for hiding this comment

noniagriconomie commented Jun 11, 2021

Jean-Beru commented Jun 11, 2021

IonBazan left a comment

Choose a reason for hiding this comment

alcaeus left a comment

Choose a reason for hiding this comment

IonBazan Jul 25, 2021

Choose a reason for hiding this comment

Jean-Beru Jul 26, 2021

Choose a reason for hiding this comment

IonBazan Jul 26, 2021

Choose a reason for hiding this comment

Jean-Beru Jul 26, 2021

Choose a reason for hiding this comment

IonBazan Jul 26, 2021

Choose a reason for hiding this comment

Jean-Beru Jul 27, 2021

Choose a reason for hiding this comment

Jean-Beru commented Jul 28, 2021

alcaeus commented Jul 29, 2021

alcaeus commented Aug 11, 2021

franmomu commented Aug 11, 2021

alcaeus commented Aug 11, 2021

Jean-Beru commented Oct 2, 2020 •

edited

Loading

IonBazan left a comment •

edited

Loading