-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make commands lazily loaded #642
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR and for patience while I was getting to it! Beside one minor styling change would you mind targeting the 4.2.x branch? The change is an improvement that we'll be happy to release as a bugfix, but it's time we sunset 3.x series.
That makes sense to me, sure. |
3072845
to
bdf4f31
Compare
Add missing spaces & mark conversation as resolved, btw
notation of inherited \Symfony\Component\Console\Command\Command? |
@kefzce one-line notation is the way to go, but also if you add it in a normal way |
Awesome, thank you @kefzce! |
This is just a fix of the previous PR #641
More info by link doctrine/migrations#839