Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make commands lazily loaded #642

Merged
merged 1 commit into from
Sep 16, 2020
Merged

Make commands lazily loaded #642

merged 1 commit into from
Sep 16, 2020

Conversation

kefzce
Copy link
Contributor

@kefzce kefzce commented Jul 24, 2020

This is just a fix of the previous PR #641

More info by link doctrine/migrations#839

Copy link

@za4me za4me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stale
Copy link

stale bot commented Aug 23, 2020

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Issues that have not seen any activity in 30 days label Aug 23, 2020
@malarzm malarzm removed the Stale Issues that have not seen any activity in 30 days label Aug 23, 2020
Copy link
Member

@malarzm malarzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR and for patience while I was getting to it! Beside one minor styling change would you mind targeting the 4.2.x branch? The change is an improvement that we'll be happy to release as a bugfix, but it's time we sunset 3.x series.

@malarzm malarzm added the Task label Sep 15, 2020
@malarzm malarzm added this to the 4.2.2 milestone Sep 15, 2020
@kefzce
Copy link
Contributor Author

kefzce commented Sep 15, 2020

Thank you for the PR and for patience while I was getting to it! Beside one minor styling change would you mind targeting the 4.2.x branch? The change is an improvement that we'll be happy to release as a bugfix, but it's time we sunset 3.x series.

That makes sense to me, sure.
Later today I will rename my branch to 4.2.x and rebase PR from 4.2.x target

@kefzce kefzce changed the base branch from 3.6.x to 4.2.x September 15, 2020 14:51
@kefzce kefzce closed this Sep 15, 2020
@kefzce kefzce deleted the 3.6.x branch September 15, 2020 14:59
@kefzce kefzce restored the 3.6.x branch September 15, 2020 14:59
@kefzce kefzce reopened this Sep 15, 2020
@kefzce
Copy link
Contributor Author

kefzce commented Sep 15, 2020

Add missing spaces & mark conversation as resolved, btw
@malarzm should I also fix CI by duplicate

    /**
     * @var string|null
     */

notation of inherited \Symfony\Component\Console\Command\Command?
If so, your Travis also tell me that you prefer single line notation instead, or it's just fine?)

@malarzm
Copy link
Member

malarzm commented Sep 15, 2020

@kefzce one-line notation is the way to go, but also if you add it in a normal way phpcbf should be able to fix it for you (it's in vendor/bin/ folder). In general we need to have a green light from CI to merge a PR :)

@malarzm
Copy link
Member

malarzm commented Sep 16, 2020

Awesome, thank you @kefzce!

@malarzm malarzm merged commit af7cc1d into doctrine:4.2.x Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants