Added a way to enable auto_mapping option using multipe document managers #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 1, 2014
| @@ -8,7 +8,7 @@ | |||
| * (c) Fabien Potencier <[email protected]> | |||
| * (c) Doctrine Project | |||
| * | |||
| * For the full copyright and license information, please view the LICENSE | |||
| * For the full copyright and license infodmation, please view the LICENSE | |||
There was a problem hiding this comment.
This seems like a simple typo fix. Can you break it out into a separate commit or, better yet, its own PR?
There was a problem hiding this comment.
@jmikola this was not fixing a typo, but introducing it
|
@jmikola fixed |
|
Created a clean commit |
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Sep 23, 2014
…ping feature (goetas) This PR was squashed before being merged into the 2.6-dev branch (closes #11815). Discussion ---------- Added some methods to improve the handling of auto_mapping feature | Q | A | ------------- | --- | Bug fix? |no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | doctrine/DoctrineBundle#60 | License | MIT This PR is a part that is required by: * doctrine/DoctrineMongoDBBundle#267 * doctrine/DoctrineBundle#321 The proposed PRs are an alternative to #11650 and doctrine/DoctrineBundle#322 Commits ------- 2e30a43 Added some methods to improve the handling of auto_mapping feature
fabpot
added a commit
to symfony/doctrine-bridge
that referenced
this pull request
Sep 23, 2014
…ping feature (goetas) This PR was squashed before being merged into the 2.6-dev branch (closes #11815). Discussion ---------- Added some methods to improve the handling of auto_mapping feature | Q | A | ------------- | --- | Bug fix? |no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | doctrine/DoctrineBundle#60 | License | MIT This PR is a part that is required by: * doctrine/DoctrineMongoDBBundle#267 * doctrine/DoctrineBundle#321 The proposed PRs are an alternative to symfony/symfony#11650 and doctrine/DoctrineBundle#322 Commits ------- 2e30a43 Added some methods to improve the handling of auto_mapping feature
| @@ -62,6 +62,8 @@ public function load(array $configs, ContainerBuilder $container) | |||
| // load the connections | |||
| $this->loadConnections($config['connections'], $container); | |||
|
|
|||
| $config['document_managers'] = $this->fixManagersAutoMappings($config['document_managers'], $container->getParameter('kernel.bundles')); | |||
There was a problem hiding this comment.
Please add the BC layer for older Symfony versions too (like in other Doctrine bundles)
|
@stof Thanks for the review, sorry if it takes so long time to fix. |
The parameter 'kernel.bundles' now is always required
|
Merged manually in 1bc023a. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds to DoctrineMongoDBBundle the same functionality of doctrine/DoctrineBundle#60
It requires the approval of symfony/symfony#11815 and would require a new min-version constraint for
symfony/doctrine-bridge(eg:~2.6if merged in SF 2.6...).