Skip to content

Commit

Permalink
Fix doctrine/coding-standard violations (#674)
Browse files Browse the repository at this point in the history
* Fix doctrine/coding-standard violations

* Remove prefer-dist option for composer
  • Loading branch information
alcaeus authored May 21, 2021
1 parent 8db802c commit 904fa3e
Show file tree
Hide file tree
Showing 5 changed files with 3 additions and 5 deletions.
1 change: 0 additions & 1 deletion .github/workflows/continuous-integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,6 @@ jobs:
uses: "ramsey/composer-install@v1"
with:
dependency-versions: "${{ matrix.dependencies }}"
composer-options: "--prefer-dist"

- name: "Run PHPUnit with coverage"
run: "vendor/bin/phpunit --coverage-clover=coverage.xml"
Expand Down
1 change: 1 addition & 0 deletions Command/DoctrineODMCommand.php
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ protected function findBundle($bundleName)
assert($bundle instanceof Bundle);
if (strtolower($bundleName) === strtolower($bundle->getName())) {
$foundBundle = $bundle;

break;
}
}
Expand Down
1 change: 1 addition & 0 deletions Command/TailCursorDoctrineODMCommand.php
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
$processor->process($document);
} catch (Throwable $e) {
$output->writeln(sprintf('Error occurred while processing document: <error>%s</error>', $e->getMessage()));

continue;
}

Expand Down
1 change: 1 addition & 0 deletions Loader/SymfonyFixturesLoader.php
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ public function getFixtures(array $groups = [])
$fixtureClass = get_class($fixture);
if (isset($this->groupsFixtureMapping[$group][$fixtureClass])) {
$filteredFixtures[$fixtureClass] = $fixture;

continue 2;
}
}
Expand Down
4 changes: 0 additions & 4 deletions phpcs.xml.dist
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,6 @@
<exclude name="SlevomatCodingStandard.Classes.SuperfluousTraitNaming" />
</rule>

<rule ref="SlevomatCodingStandard.Classes.UnusedPrivateElements.UnusedProperty">
<exclude-pattern>Tests/DependencyInjection/Fixtures/*</exclude-pattern>
</rule>

<rule ref="PSR1.Classes.ClassDeclaration.MultipleClasses">
<exclude-pattern>Tests/*</exclude-pattern>
</rule>
Expand Down

0 comments on commit 904fa3e

Please sign in to comment.