Remove baseline #473
Remove baseline #473
Conversation
|
Requires #475 , a merge up and a bump of the |
greg0ire
force-pushed
the
reduce-baseline
branch
from
f0cd427 to
628494f
Compare
greg0ire
force-pushed
the
reduce-baseline
branch
2 times, most recently
from
5a0b9f5 to
fe0a2a2
Compare
| @@ -9,6 +9,7 @@ | |||
|
|
|||
| class RequiredConstructorArgsFixtures implements ORMFixtureInterface | |||
| { | |||
| /** @phpstan-ignore constructor.unusedParameter */ | |||
There was a problem hiding this comment.
This is the only PHPStan issue left in the project, I propose we switch to phpstan-ignore for it, and now that PHPStan has error identifiers, maybe we should do that for everything.
There was a problem hiding this comment.
What's the reason for the constructor to have an argument for the test?
There was a problem hiding this comment.
That class was introduced in ee5eb61, which has a commit message that explains the reason.
Also fixing a bug where getDependencies()
Basically, currently getDependencies() won't work if any of your classes
have required constructor args. We've added a clear error message for
this situation.
There was a problem hiding this comment.
It's just for a test but maybe the ignore isn't needed when the property is set to public.
greg0ire
force-pushed
the
reduce-baseline
branch
2 times, most recently
from
67f01c4 to
5b8dd5e
Compare
greg0ire
force-pushed
the
reduce-baseline
branch
from
5b8dd5e to
d1dd451
Compare
| @@ -9,6 +9,7 @@ | |||
|
|
|||
| class RequiredConstructorArgsFixtures implements ORMFixtureInterface | |||
| { | |||
| /** @phpstan-ignore constructor.unusedParameter */ | |||
There was a problem hiding this comment.
It's just for a test but maybe the ignore isn't needed when the property is set to public.
This implies bumping psr/log to v2, which adds type declarations to its interface.
greg0ire
force-pushed
the
reduce-baseline
branch
from
d1dd451 to
aa28cd3
Compare
This implies bumping
psr/logto v2, which adds type declarations to itsinterface.