Skip to content
This repository has been archived by the owner on Oct 29, 2020. It is now read-only.

Remove int cast that prevents setting redis database from env var #153

Closed
wants to merge 1 commit into from
Closed

Remove int cast that prevents setting redis database from env var #153

wants to merge 1 commit into from

Conversation

jcerri
Copy link

@jcerri jcerri commented Mar 15, 2019

Setting redis database from env var is impossible today due to int casting since the var has not been interpreted by symfony yet.

@greg0ire
Copy link
Member

Please associate your email address with your Github account, or change the email in your commits to an address already associated with it.

@Majkl578
Copy link

Majkl578 commented Apr 1, 2019

My only concern is that what previously seemed valid: database: "default" would now throw an exception.

@aubryfr
Copy link

aubryfr commented Apr 2, 2019

Indeed. Even though, as far as I understand, default would not be a valid value for a Redis database index.

What if we keep it as a scalar node and don't cast it to an integer? It seems like it would cover what Redis expects, not alter any meaningful value, and not break what the bundle currently accepts. But it needs to be tested.

@Majkl578
Copy link

Majkl578 commented Apr 2, 2019

It wouldn't be valid but the int cast would've hidden that problem by simply concerning it to zero.

@alcaeus
Copy link
Member

alcaeus commented May 29, 2019

Closing here for the reason stated in #156.

@alcaeus alcaeus closed this May 29, 2019
@alcaeus alcaeus self-assigned this May 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants