Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Effect Chase Sinewave creates "blip" at end of cycle #247

Closed
marcusbirkin opened this issue Dec 11, 2021 · 0 comments
Closed

Effect Chase Sinewave creates "blip" at end of cycle #247

marcusbirkin opened this issue Dec 11, 2021 · 0 comments
Assignees
@marcusbirkin
Labels
bug
Milestone
v2.1.3

Comments

@marcusbirkin
Copy link
Collaborator

When running chase sinewave effect, there is a "blip" at the end of the sinewave cycle.
This is caused by an off-by-one in the index checking.
@marcusbirkin marcusbirkin added this to the v2.1.3 milestone Dec 11, 2021
@marcusbirkin marcusbirkin self-assigned this Dec 11, 2021
marcusbirkin added a commit to marcusbirkin/sacnview that referenced this issue Dec 11, 2021
@marcusbirkin
Effect Chase Sinewave creates "blip" at end of cycle
e862677 
Resolves docsteer#247
docsteer pushed a commit that referenced this issue Jan 30, 2022
@marcusbirkin
Effect Chase Sinewave creates "blip" at end of cycle
0756d28 
Resolves #247
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcusbirkin marcusbirkin

Labels
bug
Projects
None yet
Milestone
v2.1.3
Development

No branches or pull requests
1 participant
@marcusbirkin