Improve test setup #776
Merged
Improve test setup #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
provide full test setup including fixtures
provide some dummy tests cases
timaschew
force-pushed
the
improve-test-setup
branch
from
131b43d to
dac0bfe
Compare
Closed
jthegedus
approved these changes
Mar 4, 2019
There was a problem hiding this comment.
This looks good to me. (as stated elsewhere I believe we should get two reviews per PR to increase stability and spread knowledge)
My only concerns are the //TODOs that were removed, can you confirm these have been addressed by your implementation, or should they be documented to be addressed later in a different place?
|
@jthegedus |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improving test setup which allows now to init and run docsify against fixture directories which include README.md and any other files. By default an empty README.md is used (for unit tests).
@docsifyjs/core feedback welcome
masterbranch.libdirectory.