-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added slack chat integration. #236
Conversation
@janaka I've setup slack chat bot. you can review this and tell me what you think. I've also added the sample chat bot to the Docq.AI's slack work space you can try that out aswell. |
Great. I'll take a look. |
How do I do RAG? Or you waiting for the updated Web API live? |
great, I'll take a look at the code this weekend. I shipped the new Web API btw. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the whole integration is webhooks based?
This code should be part of the API I think. It also should be designed as a general webhook handler ideally.
@osala-eng you see my comment about taking a look at Nango.dev as an alternative approach? I created an account in their SaaS and sent you an invite. If we go down this path will have to self-host though. This approach would definitely allow us to have a more general API our end. |
Okay, let me check it out and get back to you.
…On Tue, 12 Mar 2024, 11:16 Janaka Abeywardhana, ***@***.***> wrote:
@osala-eng <https://github.com/osala-eng> you see my comment about taking
a look at Nango.dev as an alternative approach? I created an account in
their SaaS and sent you an invite. If we go down this path will have to
self-host though.
—
Reply to this email directly, view it on GitHub
<#236 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/APPLBJ3A7C6DQCFXHPA2K3DYX22VNAVCNFSM6AAAAABENPVKL6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJRGAYDQNRTHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments. Please respond inline.
I've not paid attention to the integrations setting / install stuff because it seems you are still working on the changes we discussed, moving those to the Admin Section.
517cc90
to
5211574
Compare
@janaka I've updated the changes as requested and implemented end to end slack chat with docq bot using RAG. |
Great. Will take a look tomorrow. |
@osala-eng sorry, I merged the Llama Index update last night. Can you rebase and check all works. Mainly with the bits that bit the Web API |
Okay, let me rebase and test this. |
great - do you have one or two tests for any of the new functionality build
for Slack and Chrome. Would be handy to know there's something.
…On Sun, 24 Mar 2024 at 16:31, Jashon Osala ***@***.***> wrote:
@osala-eng <https://github.com/osala-eng> sorry, I merged the Llama Index
update last night. Can you rebase and check all works. Mainly with the bits
that bit the Web API
Okay, let me rebase and test this.
—
Reply to this email directly, view it on GitHub
<#236 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAMUQYUMGEMXMN3SJWLRRTYZ35WVAVCNFSM6AAAAABENPVKL6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJWHA3DCOJXGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Okay let me do a quick test and get back to you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This dosent work fully as some of the functionality has been disabled.
@janaka This is now ready. |
@osala-eng did you write down anything / ref a link on how the values for the following were generated? SLACK_CLIENT_ID |
@osala-eng I just remembered about the other repo with the manifest file which answer my original question sufficiently. New related question about the env var names. You went with the SDK built-in names rather than our usual pattern of prefixing with "DOCQ_". Was that intentional for reasons like it's the only way to use the SDK? I wanted to check before refactoring to save myself some pain :) |
Yes, you can customize the env var names, then pass them explicitly to both |
add null checks
…cation. Default it on any way but this makes it more obvious when reading our code
Description
Slack chat bot integration
Implements #227
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration by modifying the list below.
Test Configuration:
Please describe the test setup. List them below as bullet points.
Checklist: