Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/pattern for backend integration testing #117

Merged
merged 21 commits into from
Oct 6, 2023

Conversation

osala-eng
Copy link
Contributor

Description

Please include a summary of the change, e.g. what the new feature # is and/or what bug # it fixes. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes/Implements #(issue/feature)

Type of change

Integration tests

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactor and code improvement (non-breaking change which improves code quality and/or performance)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation
  • Tests
  • Other chores such as maintenance

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration by modifying the list below.

  • Test A
  • Test B
  • Test C

Test Configuration:

Please describe the test setup. List them below as bullet points.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • The commit message follows the convention of this project

@osala-eng osala-eng linked an issue Oct 4, 2023 that may be closed by this pull request
Copy link
Contributor

@janaka janaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

Can you update the run test section in developer-guide > getting-started.md

@osala-eng
Copy link
Contributor Author

Looks fine.

Can you update the run test section in developer-guide > getting-started.md

Okay

@janaka
Copy link
Contributor

janaka commented Oct 6, 2023

Hey @osala-eng, what's the hold up on this PR?

@osala-eng osala-eng marked this pull request as ready for review October 6, 2023 14:32
@osala-eng osala-eng requested a review from a team as a code owner October 6, 2023 14:32
@janaka
Copy link
Contributor

janaka commented Oct 6, 2023

have you rebased?

@osala-eng
Copy link
Contributor Author

have you rebased?

Yes, I've rebased,

I still need to fix the following:

  • Fix circular dependency error between manage_users and manage_organisations
  • Update getting started docs.

@osala-eng osala-eng merged commit ead571d into main Oct 6, 2023
1 check passed
@osala-eng osala-eng deleted the TEST/pattern-for-backend-integration-testing branch October 6, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TEST: Add pattern for backend integration testing
2 participants