More server DB tests #854
More server DB tests #854
Conversation
cyli
force-pushed
the
more-server-db-test-refactor
branch
2 times, most recently
from
16af005
to
119dd7c
Compare
| @@ -14,6 +14,7 @@ type TUFFile struct { | |||
|
|
|||
| // TableName sets a specific table name for TUFFile | |||
| func (g TUFFile) TableName() string { | |||
| // NOTE: if this value changes, please also change it in SQLStorage.Delete | |||
There was a problem hiding this comment.
Is it worth making the table names constants in the storage package?
There was a problem hiding this comment.
Unfortunately we didn't want to string-interpolate an SQL statement. :| Which means hard-coding it in the DELETE string. Probably the right way to fix this is to submit a patch to GORM upstream to enable hard-delete?
Although there's this scope.Search.Unscoped check in the delete function that I don't really know how to use: https://github.com/jinzhu/gorm/blob/master/callback_delete.go#L29 - maybe that does something interesting.
There was a problem hiding this comment.
Although hmm... let me try: https://github.com/jinzhu/gorm/issues/342
There was a problem hiding this comment.
Yes that seems to work, thanks!
|
this is awesome, LGTM pending CI! |
cyli
force-pushed
the
more-server-db-test-refactor
branch
3 times, most recently
from
036333b
to
c31aa99
Compare
|
LGTM! |
|
needs a rebase |
cyli
force-pushed
the
more-server-db-test-refactor
branch
from
c31aa99
to
4b6eb60
Compare
…tion tests. Convert SQL db's deletes to hard deletes, since soft deletes would prevent us from using the same namespace in the future. Signed-off-by: Ying Li <[email protected]>
… the rethinkdb server health check to get info on the required tables, since listing tables does not check the user permission. Signed-off-by: Ying Li <[email protected]>
…dy exists in a DB, one where it doesn't Signed-off-by: Ying Li <[email protected]>
Signed-off-by: Ying Li <[email protected]>
cyli
force-pushed
the
more-server-db-test-refactor
branch
from
4b6eb60
to
3dbfaa9
Compare
This finishes the refactor in #824 of the server storage tests refactor to take a DB type.
In addition, this fixes: