Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor server/signer tests to be able to test multiple DBs (like rethink) #797

Closed
cyli opened this issue Jun 22, 2016 · 1 comment
Closed

Comments

@cyli
Copy link
Contributor

cyli commented Jun 22, 2016

It'd be nice to be able to run our storage tests against actual DBs - while we use an ORM for sql-like DBs and test against a sqlite database, our ORM may not support some of the functionality we use.

And there is no fake rethink DB right now to test, so we'd have to test our rethink code against a real DB.

@riyazdf
Copy link
Contributor

riyazdf commented Aug 2, 2016

Closing after @cyli's awesome work in #824, #854, and #863

@riyazdf riyazdf closed this as completed Aug 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants