commit_date: code cleanup and readme updates #475
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up #471 (comment)
@trim2 Fyi, I see in response schema that
commit.committer
for/repos/{owner}/{repo}/commits/{ref}
: https://docs.github.com/en/rest/commits/commits?apiVersion=2022-11-28#get-a-commitCan be null:
If that happens it would just return the current date. I think that's fine but we could improve that as follow-up. Probably warn if that happens.