Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Bake file-reference URI #330

Merged
merged 1 commit into from
Sep 8, 2023
Merged

Update Bake file-reference URI #330

merged 1 commit into from
Sep 8, 2023

Conversation

frison
Copy link
Contributor

@frison frison commented Sep 7, 2023

Previous URL 404'd

@@ -297,7 +297,7 @@ Following outputs are available
| `tags` | String | Docker tags |
| `labels` | String | Docker labels |
| `json` | String | JSON output of tags and labels |
| `bake-file` | File | [Bake file definition](https://docs.docker.com/build/customize/bake/file-definition/) path |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dvdksn We might want a redirect for this one

crazy-max
crazy-max previously approved these changes Sep 7, 2023
Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@crazy-max crazy-max self-requested a review September 7, 2023 21:29
@crazy-max crazy-max dismissed their stale review September 7, 2023 21:29

missing DCO

Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previous URL 404'd

Signed-off-by: Tim Frison <[email protected]>
Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@crazy-max crazy-max merged commit 79f06a3 into docker:master Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants