Skip to content
This repository has been archived by the owner on Sep 26, 2021. It is now read-only.

New Feature: #1342 Get an internal IP of cloud hosted machine #1355

Closed
wants to merge 1 commit into from

Conversation

aperepel
Copy link

Functional implementation for GCE, placeholders for the rest at the moment, as discussed.

…implementation for GCE and VirtualBox, placeholders for the rest currently)

Signed-off-by: Andrew Grande <[email protected]>
@aperepel
Copy link
Author

Squashed the commits, I heard you guys like them

@aperepel
Copy link
Author

Hi, the PR has been sitting green for over a month, now has a merge conflict. I am happy to resolve the conflict once again, but please let me know if there's a reason the PR wasn't merged (so I can address).

@dmp42
Copy link
Contributor

dmp42 commented Oct 21, 2015

@nathanleclaire ping

@nathanleclaire
Copy link
Contributor

It's too much stuff. Sorry @aperepel, I appreciate the effort, but features of this size and scope need to be discussed in an issue / proposal first before they will get merged in.

@nathanleclaire
Copy link
Contributor

Also would like to say sorry for the lack of responsiveness prior to this!

@schickling
Copy link

This feature would be really useful. Is there any work going on in order to make this happen @nathanleclaire? 👍

@nathanleclaire
Copy link
Contributor

@schickling No current development efforts but I agree it'd be a really useful feature to have and something we will consider strongly for machine v2.

@schickling
Copy link

@nathanleclaire Is there an official roadmap for v2?

@nathanleclaire
Copy link
Contributor

@schickling Nothing official so far, it's just been something I've been thinking about.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants