Corrected default volumes root directory for Windows #120
+16
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cpuguy83 PTAL 🤗 |
|
I don't know what this value is used for even. |
|
I found it when after build https://github.com/ContainX/docker-volume-netshare on Windows and noticed that default value for |
|
Could you switch use the existing dir layout for both windows and linux (i.e use |
olljanat
force-pushed
the
correct-default-volume-root
branch
from
57c6e90 to
ffd79ee
Compare
olljanat
changed the title
|
Ok so it on purpose like that. Updated. |
Signed-off-by: Olli Janatuinen <[email protected]>
olljanat
force-pushed
the
correct-default-volume-root
branch
from
ffd79ee to
44eeae9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that Linux default volumes root directory was
/var/lib/docker-volumesinstead of/var/lib/docker/volumesso I corrected that one + added support for Windows version.