Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add files import from SPDX #6

Merged
merged 1 commit into from
Sep 2, 2022
Merged

Add files import from SPDX #6

merged 1 commit into from
Sep 2, 2022

Conversation

jedevc
Copy link
Contributor

@jedevc jedevc commented Aug 19, 2022

List package files in output.

Note: this produces strange results if duplicate files appear in hasFiles, so we skip over them to prevent a panic (though we still produce the wrong result). For syft, this should be fixed in anchore/syft#1168.

@tonistiigi
Copy link
Member

Is the files list something that end users would find useful or is it something that could help associate the package with the command that added the package. And in that case we would add a reference to the command in here instead of the file list itself.

@jedevc
Copy link
Contributor Author

jedevc commented Sep 2, 2022

I think both have valid use cases. Knowing the command that added the package is helpful for automated patching tools, etc, but the raw file list by itself is useful I think - if after build, a user discovers an issue with a file, the package file list is an audit trail for "how did this file get here".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants