Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows 1903 fails when storage-opt used #4100

Closed
1 task done
smasherprog opened this issue Jun 19, 2019 · 10 comments
Closed
1 task done

Windows 1903 fails when storage-opt used #4100

smasherprog opened this issue Jun 19, 2019 · 10 comments

Comments

@smasherprog
Copy link

smasherprog commented Jun 19, 2019

  • [ X ] I have tried with the latest version of my channel (Stable or Edge)
  • I have uploaded Diagnostics
  • Diagnostics ID:

Expected behavior

docker run -it --storage-opt "size=60GB" mcr.microsoft.com/windows/nanoserver:1903
should work
Additionally, I have
"storage-opts": [
"size=80G"
]
added in my configuration file

Actual behavior

PS C:\Users\myusername> docker run -it --storage-opt "size=60GB" mcr.microsoft.com/windows/nanoserver:1903
C:\Program Files\Docker\Docker\Resources\bin\docker.exe: Error response from daemon: container c8ff1562a43c8474e7e149a6471532c44da1419d2b9cec06a2945f858081db79 encountered an error during Start: failure in a Windows system call: The virtual machine or container exited unexpectedly. (0xc0370106).

Information

Windows OS 1903
image

The above command always fails for any 1903 images. I have tried this on If I do not include the storage-opt, the container starts without issue.

[20:56:41.399][WindowsDaemon ][Info ] debug: form data: {"AttachStderr":true,"AttachStdin":true,"AttachStdout":true,"Cmd":null,"Domainname":"","Entrypoint":null,"Env":[],"HostConfig":{"AutoRemove":false,"Binds":null,"BlkioDeviceReadBps":null,"BlkioDeviceReadIOps":null,"BlkioDeviceWriteBps":null,"BlkioDeviceWriteIOps":null,"BlkioWeight":0,"BlkioWeightDevice":[],"CapAdd":null,"CapDrop":null,"Cgroup":"","CgroupParent":"","ConsoleSize":[50,285],"ContainerIDFile":"","CpuCount":0,"CpuPercent":0,"CpuPeriod":0,"CpuQuota":0,"CpuRealtimePeriod":0,"CpuRealtimeRuntime":0,"CpuShares":0,"CpusetCpus":"","CpusetMems":"","DeviceCgroupRules":null,"Devices":[],"DiskQuota":0,"Dns":[],"DnsOptions":[],"DnsSearch":[],"ExtraHosts":null,"GroupAdd":null,"IOMaximumBandwidth":0,"IOMaximumIOps":0,"IpcMode":"","Isolation":"process","KernelMemory":0,"Links":null,"LogConfig":{"Config":{},"Type":""},"MaskedPaths":null,"Memory":0,"MemoryReservation":0,"MemorySwap":0,"MemorySwappiness":-1,"NanoCpus":0,"NetworkMode":"default","OomKillDisable":false,"OomScoreAdj":0,"PidMode":"","PidsLimit":0,"PortBindings":{},"Privileged":false,"PublishAllPorts":false,"ReadonlyPaths":null,"ReadonlyRootfs":false,"RestartPolicy":{"MaximumRetryCount":0,"Name":"no"},"SecurityOpt":null,"ShmSize":0,"StorageOpt":{"size":"60GB"},"UTSMode":"","Ulimits":null,"UsernsMode":"","VolumeDriver":"","VolumesFrom":null},"Hostname":"","Image":"mcr.microsoft.com/windows/nanoserver:1903","Labels":{},"NetworkingConfig":{"EndpointsConfig":{}},"OnBuild":null,"OpenStdin":true,"StdinOnce":true,"Tty":true,"User":"","Volumes":{},"WorkingDir":""}
[20:56:41.400][WindowsDaemon ][Info ] debug: hcsshim::GetLayerMountPath path E:\docker\windowsfilter\ed712c7638270d5b1fb9a34e4a1706c6d295d2bd472f478852fb2aab615c84e5
[20:56:41.400][WindowsDaemon ][Info ] debug: Calling proc (1)
[20:56:41.400][WindowsDaemon ][Info ] debug: Calling proc (2)
[20:56:41.401][WindowsDaemon ][Info ] debug: hcsshim::GetLayerMountPath succeeded path=E:\docker\windowsfilter\ed712c7638270d5b1fb9a34e4a1706c6d295d2bd472f478852fb2aab615c84e5 mountPath=E:\docker\windowsfilter\ed712c7638270d5b1fb9a34e4a1706c6d295d2bd472f478852fb2aab615c84e5
[20:56:41.401][WindowsDaemon ][Info ] debug: hcsshim::CreateScratchLayer path E:\docker\windowsfilter\a7e36ae68a03d1149a5822a2c5669e2140773125c517432e79ec5c67800a8e7e
[20:56:41.401][WindowsDaemon ][Info ] debug: hcsshim::NameToGuid name:ed712c7638270d5b1fb9a34e4a1706c6d295d2bd472f478852fb2aab615c84e5 guid:3e4ccc9c-b3eb-539a-8b1b-8837d19a5c48
[20:56:41.409][WindowsDaemon ][Info ] debug: hcsshim::CreateScratchLayer - succeeded path=E:\docker\windowsfilter\a7e36ae68a03d1149a5822a2c5669e2140773125c517432e79ec5c67800a8e7e
[20:56:41.409][WindowsDaemon ][Info ] debug: hcsshim::ExpandScratchSize path=E:\docker\windowsfilter\a7e36ae68a03d1149a5822a2c5669e2140773125c517432e79ec5c67800a8e7e size=64424509440
[20:56:41.561][WindowsDaemon ][Info ] debug: hcsshim::ExpandScratchSize - succeeded path=E:\docker\windowsfilter\a7e36ae68a03d1149a5822a2c5669e2140773125c517432e79ec5c67800a8e7e size=64424509440
[20:56:41.576][ApiProxy ][Info ] time="2019-06-18T20:56:41-07:00" msg="proxy << POST /v1.39/containers/create (177.7723ms)\n"
[20:56:41.577][ApiProxy ][Info ] time="2019-06-18T20:56:41-07:00" msg="proxy >> POST /v1.39/containers/a7e36ae68a03d1149a5822a2c5669e2140773125c517432e79ec5c67800a8e7e/attach?stderr=1&stdin=1&stdout=1&stream=1\n"
[20:56:41.578][ApiProxy ][Info ] time="2019-06-18T20:56:41-07:00" msg="Upgrading to raw stream"
[20:56:41.578][ApiProxy ][Info ] time="2019-06-18T20:56:41-07:00" msg="proxy >> POST /v1.39/containers/a7e36ae68a03d1149a5822a2c5669e2140773125c517432e79ec5c67800a8e7e/wait?condition=next-exit\n"
[20:56:41.578][WindowsDaemon ][Info ] debug: Calling POST /v1.39/containers/a7e36ae68a03d1149a5822a2c5669e2140773125c517432e79ec5c67800a8e7e/attach?stderr=1&stdin=1&stdout=1&stream=1
[20:56:41.579][WindowsDaemon ][Info ] debug: attach: stderr: begin
[20:56:41.579][WindowsDaemon ][Info ] debug: attach: stdout: begin
[20:56:41.579][WindowsDaemon ][Info ] debug: attach: stdin: begin
[20:56:41.579][ApiProxy ][Info ] time="2019-06-18T20:56:41-07:00" msg="proxy >> POST /v1.39/containers/a7e36ae68a03d1149a5822a2c5669e2140773125c517432e79ec5c67800a8e7e/start [start]\n"
[20:56:41.579][WindowsDaemon ][Info ] debug: Calling POST /v1.39/containers/a7e36ae68a03d1149a5822a2c5669e2140773125c517432e79ec5c67800a8e7e/wait?condition=next-exit
[20:56:41.579][ApiProxy ][Info ] time="2019-06-18T20:56:41-07:00" msg="proxy >> POST /v1.39/containers/a7e36ae68a03d1149a5822a2c5669e2140773125c517432e79ec5c67800a8e7e/start\n"
[20:56:41.580][WindowsDaemon ][Info ] debug: Calling POST /v1.39/containers/a7e36ae68a03d1149a5822a2c5669e2140773125c517432e79ec5c67800a8e7e/start
[20:56:41.580][WindowsDaemon ][Info ] debug: WindowsGraphDriver Get() id a7e36ae68a03d1149a5822a2c5669e2140773125c517432e79ec5c67800a8e7e mountLabel
[20:56:41.585][WindowsDaemon ][Info ] debug: hcsshim::ActivateLayer path E:\docker\windowsfilter\a7e36ae68a03d1149a5822a2c5669e2140773125c517432e79ec5c67800a8e7e
[20:56:41.592][WindowsDaemon ][Info ] debug: hcsshim::ActivateLayer - succeeded path=E:\docker\windowsfilter\a7e36ae68a03d1149a5822a2c5669e2140773125c517432e79ec5c67800a8e7e
[20:56:41.593][WindowsDaemon ][Info ] debug: hcsshim::PrepareLayer path E:\docker\windowsfilter\a7e36ae68a03d1149a5822a2c5669e2140773125c517432e79ec5c67800a8e7e
[20:56:41.593][WindowsDaemon ][Info ] debug: hcsshim::NameToGuid name:ed712c7638270d5b1fb9a34e4a1706c6d295d2bd472f478852fb2aab615c84e5 guid:3e4ccc9c-b3eb-539a-8b1b-8837d19a5c48
[20:56:41.610][WindowsDaemon ][Error ] hcsshim::PrepareLayer failed in Win32: The parameter is incorrect. (0x57) path=E:\docker\windowsfilter\a7e36ae68a03d1149a5822a2c5669e2140773125c517432e79ec5c67800a8e7e
[20:56:41.610][WindowsDaemon ][Info ] debug: hcsshim::DeactivateLayer path E:\docker\windowsfilter\a7e36ae68a03d1149a5822a2c5669e2140773125c517432e79ec5c67800a8e7e
[20:56:41.637][WindowsDaemon ][Info ] debug: hcsshim::DeactivateLayer succeeded path=E:\docker\windowsfilter\a7e36ae68a03d1149a5822a2c5669e2140773125c517432e79ec5c67800a8e7e
[20:56:41.649][WindowsDaemon ][Info ] debug: WindowsGraphDriver Put() id a7e36ae68a03d1149a5822a2c5669e2140773125c517432e79ec5c67800a8e7e
[20:56:41.649][WindowsDaemon ][Info ] debug: attach: stdout: end
[20:56:41.649][WindowsDaemon ][Info ] debug: attach: stderr: end
[20:56:41.649][WindowsDaemon ][Info ] debug: attach: stdin: end
[20:56:41.649][ApiProxy ][Info ] time="2019-06-18T20:56:41-07:00" msg="proxy << POST /v1.39/containers/a7e36ae68a03d1149a5822a2c5669e2140773125c517432e79ec5c67800a8e7e/start (70.0623ms)\n"
[20:56:41.650][WindowsDaemon ][Error ] a7e36ae68a03d1149a5822a2c5669e2140773125c517432e79ec5c67800a8e7e cleanup: failed to delete container from containerd: no such container
[20:56:41.650][WindowsDaemon ][Info ] debug: attach done
[20:56:41.650][ApiProxy ][Info ] time="2019-06-18T20:56:41-07:00" msg="Cancel connection..."
[20:56:41.650][WindowsDaemon ][Info ] debug: FIXME: Got an API for which error does not match any expected type!!!: hcsshim::PrepareLayer failed in Win32: The parameter is incorrect. (0x57) path=E:\docker\windowsfilter\a7e36ae68a03d1149a5822a2c5669e2140773125c517432e79ec5c67800a8e7e [module=api error_type=*hcserror.HcsError]
[20:56:41.650][ApiProxy ][Info ] time="2019-06-18T20:56:41-07:00" msg="proxy << POST /v1.39/containers/a7e36ae68a03d1149a5822a2c5669e2140773125c517432e79ec5c67800a8e7e/attach?stderr=1&stdin=1&stdout=1&stream=1 (73.0527ms)\n"
[20:56:41.650][WindowsDaemon ][Error ] Handler for POST /v1.39/containers/a7e36ae68a03d1149a5822a2c5669e2140773125c517432e79ec5c67800a8e7e/start returned error: hcsshim::PrepareLayer failed in Win32: The parameter is incorrect. (0x57) path=E:\docker\windowsfilter\a7e36ae68a03d1149a5822a2c5669e2140773125c517432e79ec5c67800a8e7e
[20:56:41.650][WindowsDaemon ][Info ] debug: FIXME: Got an API for which error does not match any expected type!!!: hcsshim::PrepareLayer failed in Win32: The parameter is incorrect. (0x57) path=E:\docker\windowsfilter\a7e36ae68a03d1149a5822a2c5669e2140773125c517432e79ec5c67800a8e7e [module=api error_type=*hcserror.HcsError]
[20:56:41.650][ApiProxy ][Info ] time="2019-06-18T20:56:41-07:00" msg="proxy << POST /v1.39/containers/a7e36ae68a03d1149a5822a2c5669e2140773125c517432e79ec5c67800a8e7e/wait?condition=next-exit (72.0542ms)\n"
[20:56:41.650][WindowsDaemon ][Info ] debug: Closing buffered stdin pipe
[20:57:02.858][ApiProxy ][Info ] time="2019-06-18T20:57:02-07:00" msg="proxy >> GET /_ping\n"
[20:57:02.859][ApiProxy ][Info ] time="2019-06-18T20:57:02-07:00" msg="proxy << GET /_ping (0s)\n"
[20:57:02.859][WindowsDaemon ][Info ] debug: Calling GET /_ping
[20:57:02.861][ApiProxy ][Info ] time="2019-06-18T20:57:02-07:00" msg="proxy >> POST /v1.39/containers/create [rewriteBinds]\n"
[20:57:02.861][ApiProxy ][Info ] time="2019-06-18T20:57:02-07:00" msg="proxy >> POST /v1.39/containers/create\n"
[20:57:02.862][WindowsDaemon ][Info ] debug: Calling POST /v1.39/containers/create
[20:57:02.862][WindowsDaemon ][Info ] debug: form data: {"AttachStderr":true,"AttachStdin":false,"AttachStdout":true,"Cmd":null,"Domainname":"","Entrypoint":null,"Env":[],"HostConfig":{"AutoRemove":false,"Binds":null,"BlkioDeviceReadBps":null,"BlkioDeviceReadIOps":null,"BlkioDeviceWriteBps":null,"BlkioDeviceWriteIOps":null,"BlkioWeight":0,"BlkioWeightDevice":[],"CapAdd":null,"CapDrop":null,"Cgroup":"","CgroupParent":"","ConsoleSize":[50,285],"ContainerIDFile":"","CpuCount":0,"CpuPercent":0,"CpuPeriod":0,"CpuQuota":0,"CpuRealtimePeriod":0,"CpuRealtimeRuntime":0,"CpuShares":0,"CpusetCpus":"","CpusetMems":"","DeviceCgroupRules":null,"Devices":[],"DiskQuota":0,"Dns":[],"DnsOptions":[],"DnsSearch":[],"ExtraHosts":null,"GroupAdd":null,"IOMaximumBandwidth":0,"IOMaximumIOps":0,"IpcMode":"","Isolation":"","KernelMemory":0,"Links":null,"LogConfig":{"Config":{},"Type":""},"MaskedPaths":null,"Memory":0,"MemoryReservation":0,"MemorySwap":0,"MemorySwappiness":-1,"NanoCpus":0,"NetworkMode":"default","OomKillDisable":false,"OomScoreAdj":0,"PidMode":"","PidsLimit":0,"PortBindings":{},"Privileged":false,"PublishAllPorts":false,"ReadonlyPaths":null,"ReadonlyRootfs":false,"RestartPolicy":{"MaximumRetryCount":0,"Name":"no"},"SecurityOpt":null,"ShmSize":0,"StorageOpt":{"size":"60GB"},"UTSMode":"","Ulimits":null,"UsernsMode":"","VolumeDriver":"","VolumesFrom":null},"Hostname":"","Image":"mcr.microsoft.com/windows/nanoserver:1903","Labels":{},"NetworkingConfig":{"EndpointsConfig":{}},"OnBuild":null,"OpenStdin":false,"StdinOnce":false,"Tty":false,"User":"","Volumes":{},"WorkingDir":""}
[20:57:02.863][WindowsDaemon ][Info ] debug: hcsshim::GetLayerMountPath path E:\docker\windowsfilter\ed712c7638270d5b1fb9a34e4a1706c6d295d2bd472f478852fb2aab615c84e5
[20:57:02.864][WindowsDaemon ][Info ] debug: Calling proc (1)
[20:57:02.864][WindowsDaemon ][Info ] debug: Calling proc (2)
[20:57:02.865][WindowsDaemon ][Info ] debug: hcsshim::GetLayerMountPath succeeded path=E:\docker\windowsfilter\ed712c7638270d5b1fb9a34e4a1706c6d295d2bd472f478852fb2aab615c84e5 mountPath=E:\docker\windowsfilter\ed712c7638270d5b1fb9a34e4a1706c6d295d2bd472f478852fb2aab615c84e5
[20:57:02.865][WindowsDaemon ][Info ] debug: hcsshim::CreateScratchLayer path E:\docker\windowsfilter\f77e4b334ec015fc863ac7a559dc9b43d8f131c5b26bd60e5a3473dc5d02746b
[20:57:02.865][WindowsDaemon ][Info ] debug: hcsshim::NameToGuid name:ed712c7638270d5b1fb9a34e4a1706c6d295d2bd472f478852fb2aab615c84e5 guid:3e4ccc9c-b3eb-539a-8b1b-8837d19a5c48
[20:57:02.868][WindowsDaemon ][Info ] debug: hcsshim::CreateScratchLayer - succeeded path=E:\docker\windowsfilter\f77e4b334ec015fc863ac7a559dc9b43d8f131c5b26bd60e5a3473dc5d02746b
[20:57:02.868][WindowsDaemon ][Info ] debug: hcsshim::ExpandScratchSize path=E:\docker\windowsfilter\f77e4b334ec015fc863ac7a559dc9b43d8f131c5b26bd60e5a3473dc5d02746b size=64424509440
[20:57:02.986][WindowsDaemon ][Info ] debug: hcsshim::ExpandScratchSize - succeeded path=E:\docker\windowsfilter\f77e4b334ec015fc863ac7a559dc9b43d8f131c5b26bd60e5a3473dc5d02746b size=64424509440
[20:57:03.002][ApiProxy ][Info ] time="2019-06-18T20:57:03-07:00" msg="proxy << POST /v1.39/containers/create (139.4647ms)\n"
[20:57:03.002][ApiProxy ][Info ] time="2019-06-18T20:57:03-07:00" msg="proxy >> POST /v1.39/containers/f77e4b334ec015fc863ac7a559dc9b43d8f131c5b26bd60e5a3473dc5d02746b/attach?stderr=1&stdout=1&stream=1\n"
[20:57:03.003][ApiProxy ][Info ] time="2019-06-18T20:57:03-07:00" msg="Upgrading to raw stream"
[20:57:03.004][WindowsDaemon ][Info ] debug: Calling POST /v1.39/containers/f77e4b334ec015fc863ac7a559dc9b43d8f131c5b26bd60e5a3473dc5d02746b/attach?stderr=1&stdout=1&stream=1
[20:57:03.004][ApiProxy ][Info ] time="2019-06-18T20:57:03-07:00" msg="proxy >> POST /v1.39/containers/f77e4b334ec015fc863ac7a559dc9b43d8f131c5b26bd60e5a3473dc5d02746b/wait?condition=next-exit\n"
[20:57:03.004][WindowsDaemon ][Info ] debug: attach: stdout: begin
[20:57:03.004][WindowsDaemon ][Info ] debug: attach: stderr: begin
[20:57:03.006][WindowsDaemon ][Info ] debug: Calling POST /v1.39/containers/f77e4b334ec015fc863ac7a559dc9b43d8f131c5b26bd60e5a3473dc5d02746b/wait?condition=next-exit
[20:57:03.006][ApiProxy ][Info ] time="2019-06-18T20:57:03-07:00" msg="proxy >> POST /v1.39/containers/f77e4b334ec015fc863ac7a559dc9b43d8f131c5b26bd60e5a3473dc5d02746b/start [start]\n"
[20:57:03.006][ApiProxy ][Info ] time="2019-06-18T20:57:03-07:00" msg="proxy >> POST /v1.39/containers/f77e4b334ec015fc863ac7a559dc9b43d8f131c5b26bd60e5a3473dc5d02746b/start\n"
[20:57:03.007][WindowsDaemon ][Info ] debug: Calling POST /v1.39/containers/f77e4b334ec015fc863ac7a559dc9b43d8f131c5b26bd60e5a3473dc5d02746b/start
[20:57:03.015][WindowsDaemon ][Info ] debug: Assigning addresses for endpoint brave_gagarin's interface on network nat
[20:57:03.015][WindowsDaemon ][Info ] debug: RequestAddress(0.0.0.0/0, , map[])
[20:57:03.015][WindowsDaemon ][Info ] debug: endpointStruct.EnableInternalDNS =[false]
[20:57:03.015][WindowsDaemon ][Info ] debug: [POST]=>[/endpoints/] Request : {"VirtualNetwork":"234F0C8F-7FD2-40A7-8B77-EB278C8D05B7","EnableInternalDNS":true}
[20:57:03.024][WindowsDaemon ][Info ] debug: Network Response : {"ActivityId":"D754130E-E361-402C-B6CE-F1F1D3E50009","AdditionalParams":{},"CreateProcessingStartTime":132053902230192699,"DNSServerList":"172.17.144.1,192.168.1.1","EnableInternalDNS":true,"EnableLowInterfaceMetric":true,"EncapOverhead":0,"Flags":0,"GatewayAddress":"172.17.144.1","Health":{"LastErrorCode":0,"LastUpdateTime":132053902230192699},"ID":"967E36EA-9251-4E0E-9AE9-0CA221A35C9D","IPAddress":"172.17.150.204","MacAddress":"00-15-5D-4C-A9-40","Name":"Ethernet","Policies":[],"PrefixLength":20,"SharedContainers":[],"State":1,"Type":"nat","Version":42949672963,"VirtualNetwork":"234F0C8F-7FD2-40A7-8B77-EB278C8D05B7","VirtualNetworkName":"nat","Resources":{"AdditionalParams":{},"AllocationOrder":0,"CompartmentOperationTime":0,"Flags":0,"Health":{"LastErrorCode":0,"LastUpdateTime":132053902230192699},"ID":"D754130E-E361-402C-B6CE-F1F1D3E50009","PortOperationTime":0,"State":1,"SwitchOperationTime":0,"VfpOperationTime":0,"parentId":"2BA078B4-1473-4982-9E32-4FB5671CB56F"}}

@cchuter
Copy link

cchuter commented Jul 10, 2019

We have this problem as well and we cannot update a bunch of machines to 1903 because of this.

@smasherprog
Copy link
Author

Same here we are holding back on updating windows until this is resolved

@npross
Copy link

npross commented Sep 30, 2019

any resolution for this issue?

@bobbytreed
Copy link

Still having issues with this as well. When is a fix expected?

thaJeztah added a commit to thaJeztah/cli that referenced this issue Jan 7, 2020
full diff: https://2226e083fc390003ae5aa8325c3c92789afa0e7a...b3f49c06ffaeef24d09c6c08ec8ec8425a0303e2

includes:

- microsoft/hcsshim#718 wclayer: Work around Windows bug when expanding sandbox size
    - fixes microsoft/hcsshim#708 Windows Host Compute Service bug breaks docker (and other) sandboxes bigger than 20G on Windows 1903
    - fixes microsoft/hcsshim#624The hcsshim on Windows 10 1903 always fails to build Docker image
    - fixes/addresses docker/for-win#3884 An error occurred while attempting to build Docker image (especially this comment and the next comments after: docker/for-win#3884 (comment))
    - fixes/addresses docker/for-win#4100 Windows 1903 fails when storage-opt used
    - fixes moby/moby#36831 hcsshim::PrepareLayer failed in Win32: The parameter is incorrect (moby/moby#36831 (comment))
    - fixes Stannieman/audacity-with-asio-builder#5 Docker won't build container
    - fixes MicrosoftDocs/visualstudio-docs#3523 Error when running build with storage-opts set
    - fixes moby/moby#39524 Docker build windows 19.03 --storage-opt size>20G

Note that this is a temporary workaround for a bug in the platform, and will be reverted once that is addressed:

- microsoft/hcsshim#721 Revert 718 when Windows 19H1 has expand sandbox fix

Signed-off-by: Sebastiaan van Stijn <[email protected]>
docker-jenkins pushed a commit to docker-archive/docker-ce that referenced this issue Jan 9, 2020
full diff: https://2226e083fc390003ae5aa8325c3c92789afa0e7a...b3f49c06ffaeef24d09c6c08ec8ec8425a0303e2

includes:

- microsoft/hcsshim#718 wclayer: Work around Windows bug when expanding sandbox size
    - fixes microsoft/hcsshim#708 Windows Host Compute Service bug breaks docker (and other) sandboxes bigger than 20G on Windows 1903
    - fixes microsoft/hcsshim#624The hcsshim on Windows 10 1903 always fails to build Docker image
    - fixes/addresses docker/for-win#3884 An error occurred while attempting to build Docker image (especially this comment and the next comments after: docker/for-win#3884 (comment))
    - fixes/addresses docker/for-win#4100 Windows 1903 fails when storage-opt used
    - fixes moby/moby#36831 hcsshim::PrepareLayer failed in Win32: The parameter is incorrect (moby/moby#36831 (comment))
    - fixes Stannieman/audacity-with-asio-builder#5 Docker won't build container
    - fixes MicrosoftDocs/visualstudio-docs#3523 Error when running build with storage-opts set
    - fixes moby/moby#39524 Docker build windows 19.03 --storage-opt size>20G

Note that this is a temporary workaround for a bug in the platform, and will be reverted once that is addressed:

- microsoft/hcsshim#721 Revert 718 when Windows 19H1 has expand sandbox fix

Signed-off-by: Sebastiaan van Stijn <[email protected]>
Upstream-commit: dff269b5e4b8dc86d12116ac5dff9caca49593d9
Component: cli
@TBBle
Copy link

TBBle commented Feb 1, 2020

Looks like there'll be a fix (workaround) in Docker Engine 19.03.6, see https://github.com/docker/docker-ce/releases and docker-archive/engine#429.

@docker-robott
Copy link
Collaborator

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale comment.
Stale issues will be closed after an additional 30d of inactivity.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so.

Send feedback to Docker Community Slack channels #docker-for-mac or #docker-for-windows.
/lifecycle stale

@TBBle
Copy link

TBBle commented May 10, 2020

On my Windows 1909 desktop with Docker Desktop for Windows 2.2.0.5 (43884) which includes Docker Engine 19.03.8, in Windows Container mode, the above-linked workaround appears to be working now, so this issue can probably be closed.


PS C:\Users\paulh> docker run -it --storage-opt "size=90GB" mcr.microsoft.com/windows/nanoserver:1909
Microsoft Windows [Version 10.0.18363.592]
(c) 2019 Microsoft Corporation. All rights reserved.

C:\>dir
 Volume in drive C has no label.
 Volume Serial Number is 66BD-C698

 Directory of C:\

01/04/2020  11:52 AM             5,510 License.txt
05/10/2020  05:00 PM    <DIR>          Users
05/10/2020  05:00 PM    <DIR>          Windows
               1 File(s)          5,510 bytes
               2 Dir(s)  96,462,082,048 bytes free

C:\>exit

Edit %PROGRAMDATA%\Docker\config\daemon.json:

{
  "registry-mirrors": [],
  "insecure-registries": [],
  "debug": true,
  "experimental": false,
  "storage-opts": [
    "size=60GB"
  ]
}

Then restart the Docker daemon. (Thanks to @rgalonso for pointing this out)

Now the other test works:

PS C:\Users\paulh> docker run -it mcr.microsoft.com/windows/nanoserver:1909
Microsoft Windows [Version 10.0.18363.592]
(c) 2019 Microsoft Corporation. All rights reserved.

C:\>dir
 Volume in drive C has no label.
 Volume Serial Number is 66BD-C698

 Directory of C:\

01/04/2020  11:52 AM             5,510 License.txt
05/10/2020  04:59 PM    <DIR>          Users
05/10/2020  04:59 PM    <DIR>          Windows
               1 File(s)          5,510 bytes
               2 Dir(s)  64,250,974,208 bytes free

Version info:

PS C:\Users\paulh> cmd /c ver

Microsoft Windows [Version 10.0.18363.815]
PS C:\Users\paulh> docker version
Client: Docker Engine - Community
 Version:           19.03.8
 API version:       1.40
 Go version:        go1.12.17
 Git commit:        afacb8b
 Built:             Wed Mar 11 01:23:10 2020
 OS/Arch:           windows/amd64
 Experimental:      true

Server: Docker Engine - Community
 Engine:
  Version:          19.03.8
  API version:      1.40 (minimum version 1.24)
  Go version:       go1.12.17
  Git commit:       afacb8b
  Built:            Wed Mar 11 01:37:20 2020
  OS/Arch:          windows/amd64
  Experimental:     false

Edit: I noticed afterwards that my nanoserver image was out of date. I pulled mcr.microsoft.com/windows/nanoserver:1909, which is now reporting Microsoft Windows [Version 10.0.18363.778] inside the container, and it still works.

@rgalonso
Copy link

@TBBle, thank you for the detailed instructions on how to verify the issue is resolved. (It had been so many months since I subscribed to this issue that I'd forgotten why I even cared and how to replicate the issue!)

For others who read your note too, it may be helpful to clarify that after modifying daemon.json, you need to restart Docker Desktop in order for that change to be applied. Thanks again!

@mat007
Copy link
Member

mat007 commented May 13, 2020

Thanks @TBBle and @rgalonso, I’ll go ahead and close this issue then.

@mat007 mat007 closed this as completed May 13, 2020
@docker-robott
Copy link
Collaborator

Closed issues are locked after 30 days of inactivity.
This helps our team focus on active issues.

If you have found a problem that seems similar to this, please open a new issue.

Send feedback to Docker Community Slack channels #docker-for-mac or #docker-for-windows.
/lifecycle locked

@docker docker locked and limited conversation to collaborators Jul 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants