Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Critical Issue Stopping Downloads of Docker (#6910) (#7179) #7242

Merged
merged 4 commits into from
Sep 25, 2018
Merged

Fixes Critical Issue Stopping Downloads of Docker (#6910) (#7179) #7242

merged 4 commits into from
Sep 25, 2018

Conversation

WriteCodeEveryday
Copy link
Contributor

@WriteCodeEveryday WriteCodeEveryday commented Aug 21, 2018 •
edited
Loading

Proposed changes

Ensures downloads of Docker are functional for users.

Related issues (optional)

Refer to related issue (closed by mistake, obviously)
#6910
#7179

@WriteCodeEveryday
Update install.md to fix critical issue.
d135401 
This ensures users can download Docker without any issues.
@WriteCodeEveryday
Update install.md to fix critical issue.
f383305 
This ensures users can download Docker without any issues.
@WriteCodeEveryday
Update install.md
626c212
@GordonTheTurtle
Copy link

Deploy preview for modest-edison-79d82e ready!

Built with commit f383305

https://deploy-preview-7242--modest-edison-79d82e.netlify.com

@Nicnl
Copy link

Nicnl commented Aug 21, 2018

LGTM.

No need to create an account to download Docker.

@WriteCodeEveryday
Copy link
Contributor Author

There's a small issue with the CSS for primary-btn, so I'm just going to revert back to outline-btn.

@GordonTheTurtle
Copy link

Deploy preview for modest-edison-79d82e ready!

Built with commit 626c212

https://deploy-preview-7242--modest-edison-79d82e.netlify.com

@GordonTheTurtle
Copy link

Deploy preview for modest-edison-79d82e ready!

Built with commit d943215

https://deploy-preview-7242--modest-edison-79d82e.netlify.com

@joydashy
Copy link

A very welcome feature indeed, should be merged ASAP!

@WriteCodeEveryday WriteCodeEveryday changed the title Fixes Critical Issue Stopping Downloads of Docker Fixes Critical Issue Stopping Downloads of Docker (#6910) (#7179) Aug 21, 2018
sgairo
sgairo approved these changes Aug 21, 2018
View reviewed changes
Copy link

@sgairo sgairo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rvoortman
Copy link

Any news on when this will be merged?

@WriteCodeEveryday
Copy link
Contributor Author

@rvoortman Not sure, ask @vieux and @#2jmorganca.

It does seem to have a lot of approvals so it shouldn't have an issue being merged.

@ahh-docker ahh-docker closed this Sep 25, 2018
@ahh-docker ahh-docker reopened this Sep 25, 2018
@ahh-docker ahh-docker self-assigned this Sep 25, 2018
@ahh-docker ahh-docker merged commit 8f97bb2 into docker:master Sep 25, 2018
@ahh-docker ahh-docker added the area/install Relates to installing a product label Sep 25, 2018
@ahh-docker ahh-docker mentioned this pull request Sep 25, 2018
Closed
@JustinINevill JustinINevill mentioned this pull request Sep 28, 2018
Merged
@peterbraden
Copy link
Contributor

This was reverted here: #7446

@MichaelSp
Copy link

Please reopen. Problem persists!

@WriteCodeEveryday
Copy link
Contributor Author

WriteCodeEveryday commented Oct 5, 2018 •
edited
Loading

@JustinINevill Why was this reverted?

@ahh-docker Someone is reverting your merges, please ensure their accounts have not been compromised.

@WriteCodeEveryday WriteCodeEveryday mentioned this pull request Oct 5, 2018
Closed
@rvoortman
Copy link

rvoortman commented Oct 5, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NuclearCookie NuclearCookie NuclearCookie approved these changes

@hoerup hoerup hoerup approved these changes

@manojlds manojlds manojlds approved these changes

@skycoop skycoop skycoop approved these changes

@johnke johnke johnke approved these changes

@OliverCole OliverCole OliverCole approved these changes

@coldacid coldacid coldacid approved these changes

@lol768 lol768 lol768 approved these changes

@RobThree RobThree RobThree approved these changes

@thimslugga thimslugga thimslugga approved these changes

@mariusgrigaitis mariusgrigaitis mariusgrigaitis approved these changes

@nyanpasu64 nyanpasu64 nyanpasu64 approved these changes

@bn4t bn4t bn4t approved these changes

@vnataraj vnataraj vnataraj approved these changes

@bxt bxt bxt approved these changes

@TheWildHorse TheWildHorse TheWildHorse approved these changes

@cyungmann cyungmann cyungmann approved these changes

@ConorMcGee ConorMcGee ConorMcGee approved these changes

@billinghamj billinghamj billinghamj approved these changes

@apank apank apank approved these changes

@mbabker mbabker mbabker approved these changes

@CraigHarley CraigHarley CraigHarley approved these changes

@fattredd fattredd fattredd approved these changes

@WarlaxZ WarlaxZ WarlaxZ approved these changes

@solracsf solracsf solracsf approved these changes

@alessioalex alessioalex alessioalex approved these changes

@sgairo sgairo sgairo approved these changes

@jgowdy jgowdy jgowdy approved these changes

@macbem macbem macbem approved these changes

@MichaelSp MichaelSp MichaelSp approved these changes

@jcherniak jcherniak jcherniak approved these changes

@rbeuque74 rbeuque74 rbeuque74 approved these changes

@cailin-telenor cailin-telenor cailin-telenor approved these changes

@cyrankiewicz cyrankiewicz cyrankiewicz approved these changes

@KZeillmann KZeillmann KZeillmann approved these changes

Assignees

@ahh-docker ahh-docker

Labels
area/install Relates to installing a product
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.