Update note about custom certs with system certs #417
Conversation
|
This was closed due to some unrelated |
| > will use the system default (i.e., host's root CA set). | ||
| > As of docker 1.13, on Linux any root certificates authorities will be merged | ||
| > in with the system defaults (i.e., host's root CA set). Prior to 1.13 and on | ||
| > Windows, the system default certificates will only be used when there are no |
There was a problem hiding this comment.
asked @dmcgowan and unfortunately, the Go update required for this feature wasn't implemented for Windows
There was a problem hiding this comment.
@thaJeztah this is only tangentially related to this change, but I'm wondering if you need to restart the Docker daemon for Docker to load these certificates?
My understanding is that if you were adding certs to the host trusted CA store, you would need to restart the daemon. If you do need to restart, maybe we need to mention it.
There was a problem hiding this comment.
golang/go#16736, looks like will be fixed in 1.8
There was a problem hiding this comment.
@joaofnfernandes restart is not needed, these certificates are always read at the start of a push or pull operation and not kept around after
|
oh, hold on, this should be in the |
Fixed incorrect statement about example layout Related to moby/moby#27918 Signed-off-by: Derek McGowan <[email protected]> (github: dmcgowan)
dmcgowan
force-pushed
the
merge-system-roots
branch
from
b4fb501
to
f18c670
Compare
|
It's on the right branch now, and moby/moby#27918 was merged, so this should probably be ready to go. @joaofnfernandes for review/merge 😄 |
|
@dmcgowan thanks for helping with docs. |
- Close docker#194 and fix - Fix and close docker#425 - Fix and close docker#417 - Fix and close docker#420 - Fix and close docker#422 - Adding in documentation build scripts - Fix and close docker#431 - Fix and close docker#438, and Fix and close docker#429 - Work on 441 - Adding in commands reference - Updating all the options to tables - Updating per Vivek docker#498 - Adding vivek's last suggestions Signed-off-by: Mary Anthony <[email protected]>
Describe the proposed changes
Docker 1.13 will now merge custom certificates with the system certificate pool. This change updates the note about when the system certificate pool is used. Also fixed incorrect statement about example layout. The example was only showing custom certificates, and not multiple certificates.
Project version
Docker Engine 1.13
Related issue or PR in another project
moby/moby#27918
Please take a look
@thaJeztah