Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dockerd config location #19082

Merged
merged 6 commits into from
Jan 11, 2024
Merged

dockerd config location #19082

merged 6 commits into from
Jan 11, 2024

Conversation

dvdksn
Copy link
Collaborator

@dvdksn dvdksn commented Jan 11, 2024 •
edited
Loading

Proposed changes

  • engine: clarify daemon.json config file location
  • engine: move "next steps" to separate section
  • engine: remove incorrect statement about proxy config with daemon.json

Related issues (optional)

Relates to moby/moby#47058

@netlify Netlify
Copy link

netlify bot commented Jan 11, 2024 •
edited
Loading

✅ Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 553f5b7
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/659ffd3a2f20f700088f5fb5
😎 Deploy Preview https://deploy-preview-19082--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dvdksn dvdksn requested a review from thaJeztah January 11, 2024 12:49
@dvdksn dvdksn added the area/engine Issue affects Docker engine/daemon label Jan 11, 2024
thaJeztah
thaJeztah reviewed Jan 11, 2024
View reviewed changes
content/config/daemon/_index.md Outdated Show resolved Hide resolved
content/config/daemon/_index.md Show resolved Hide resolved
content/config/daemon/_index.md Show resolved Hide resolved
@github-actions github-actions bot removed the area/engine Issue affects Docker engine/daemon label Jan 11, 2024
@dvdksn dvdksn requested a review from thaJeztah January 11, 2024 19:13
@dvdksn dvdksn added the area/engine Issue affects Docker engine/daemon label Jan 11, 2024
@dvdksn dvdksn self-assigned this Jan 11, 2024
thaJeztah
thaJeztah approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@thaJeztah thaJeztah merged commit 9a55d59 into docker:main Jan 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thaJeztah thaJeztah thaJeztah approved these changes

Assignees

@dvdksn dvdksn

Labels
area/engine Issue affects Docker engine/daemon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dvdksn @thaJeztah