Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(ci): distribute build across multiple runners #17180

Merged
merged 1 commit into from
May 9, 2023

Conversation

crazy-max
Copy link
Member

Proposed changes

Adds an example using a matrix strategy to distribute the build for each platform across multiple runners and merge the resulting manifests into a single image using the buildx imagetools create command.

Related issues (optional)

fixes #16593

cc @kaovilai

@crazy-max crazy-max requested review from jedevc and dvdksn April 25, 2023 09:10
@netlify
Copy link

netlify bot commented Apr 25, 2023

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit b952032
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/644798fc6fac5400081d5739
😎 Deploy Preview https://deploy-preview-17180--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link

@kaovilai kaovilai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome 😎

Copy link
Contributor

@dvdksn dvdksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a local registry for this is so cool

@crazy-max crazy-max added the area/build Relates to Dockerfiles or docker build command label May 4, 2023
@crazy-max
Copy link
Member Author

I go ahead and merge this one. In follow-up I think we could provide a composite action for a better integration so user would not need to add extra steps to load, push the local image but also handling of imagetools command.

@crazy-max crazy-max merged commit d192ff7 into docker:main May 9, 2023
@crazy-max crazy-max deleted the build-gha-merge-image branch May 9, 2023 09:50
@jedevc
Copy link
Contributor

jedevc commented May 9, 2023

SGTM 🎉

Realized I hadn't shared my thoughts from a DM with @crazy-max:

alternatively. we can use the push-by-digest key i think (might wanna check my sources on that), to only push the digest - then we grab the digests from the buildx output digest, and combine those

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build Relates to Dockerfiles or docker build command needs/follow-up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Github Actions Matrix Strategy Multi-Arch built on multiple runners
4 participants