-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release notes for Docker Desktop 4.0.1 #13486
Conversation
✔️ Deploy Preview for docsdocker ready! 🔨 Explore the source changes: b76fc94 🔍 Inspect the deploy log: https://app.netlify.com/sites/docsdocker/deploys/613f4f80e6ff93000844432c 😎 Browse the preview: https://deploy-preview-13486--docsdocker.netlify.app |
desktop/mac/release-notes.md
Outdated
> {%- include eula.md -%} | ||
> | ||
> [Mac with Intel chip](https://desktop.docker.com/mac/stable/amd64/67817/Docker.dmg){: .accept-eula } | | ||
> [Mac with Apple chip](https://desktop.docker.com/mac/stable/arm64/67817/Docker.dmg){: .accept-eula } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the accept-eula classes are not needed for v4.0 and up (because docker desktop itself will ask the user to accept)
desktop/mac/release-notes.md
Outdated
|
||
## Docker Desktop 4.0.0 | ||
2021-08-31 | ||
|
||
> Download Docker Desktop | ||
> | ||
> [Mac with Intel chip](https://desktop.docker.com/mac/stable/amd64/Docker.dmg?utm_source=docker&utm_medium=webreferral&utm_campaign=docs-driven-download-mac-amd64){: .button .primary-btn } | ||
> [Mac with Apple chip](https://desktop.docker.com/mac/stable/arm64/Docker.dmg?utm_source=docker&utm_medium=webreferral&utm_campaign=docs-driven-download-mac-arm64){: .button .primary-btn } | ||
> {%- include eula.md -%} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps the eula include as well 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh I just copied pasted from the last part! 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the older releases did not have the "accept agreement" in the installer, which is why it was added in the docs. Now that all new binaries we ship have this, I think we can remove it for the new downloads, so if could be simplified to:
> Download Docker Desktop
>
> [Mac with Intel chip](https://desktop.docker.com/mac/stable/amd64/67817/Docker.dmg) |
> [Mac with Apple chip](https://desktop.docker.com/mac/stable/arm64/67817/Docker.dmg)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that makes sense. We don't need the EULA class for 4.0 and higher releases
e228bf9
to
360daec
Compare
@lorenrh Buildx 0.6.3 is not part of this release? (fixes docker/buildx#751) |
@crazy-max not for 4.0.1. It is planned for the 4.1.0 release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Signed-off-by: Lorena Rangel <[email protected]>
360daec
to
b76fc94
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Lorena Rangel [email protected]
Proposed changes
Unreleased project version (optional)
Related issues (optional)