Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pause option to commit api #3159

Merged
merged 2 commits into from
Aug 14, 2023
Merged

Conversation

VincentLeeMax
Copy link
Contributor

When using container.commit() function, it default to pause the container before committing. In some case that could't pause the container, we need to use container.commit(pause=False)

Signed-off-by: VincentLeeMax <[email protected]>
Copy link
Contributor

@milas milas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

From https://docs.docker.com/engine/api/v1.43/#tag/Image/operation/ImageCommit:

pause [boolean]
Default: true
Whether to pause the container before committing

@milas milas merged commit 4571f7f into docker:main Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants