Fix container.stats infinite blocking on stream mode #3120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@milas ptal |
Includes additional test for no streaming Signed-off-by: Bharath Vignesh J K <[email protected]>
milas
approved these changes
May 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Issue: #3118
Cause
The HTTP client is not invoked with the stream mode when making the GET HTTP call for the stats API, leading to the client trying to read the whole response instead of treating it as a stream, causing a infinite block.
This seems to be a regression from e9d4ddf
Fix
Add the removed
streamparameter when making the GET Request callNotes
Includes additional test for non streaming mode
Fixes #3118