Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osxkeychain: match min macos version for xx #283

Merged
merged 1 commit into from
May 28, 2023

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented May 27, 2023

partially solves #280

xx sets a minimal macos version if not set through MACOSX_VERSION_MIN env var: https://github.com/tonistiigi/xx/blob/3d00d096c8bf894ec29bae5caa5aea81d9c187a5/base/xx-info#L203-L209

@codecov-commenter
Copy link

codecov-commenter commented May 27, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0b91805) 55.23% compared to head (5944f8a) 55.23%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #283   +/-   ##
=======================================
  Coverage   55.23%   55.23%           
=======================================
  Files           9        9           
  Lines         668      668           
=======================================
  Hits          369      369           
  Misses        256      256           
  Partials       43       43           
Impacted Files Coverage Δ
osxkeychain/osxkeychain_darwin.go 69.10% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@thaJeztah
Copy link
Member

Haven't tried yet, but wondering if we need to update these two lines;

#cgo CFLAGS: -x objective-c -mmacosx-version-min=10.11
#cgo LDFLAGS: -framework Security -framework Foundation -mmacosx-version-min=10.11

@crazy-max crazy-max force-pushed the fix-osx-min-version branch from abe5b9d to f53a494 Compare May 28, 2023 13:12
@crazy-max crazy-max force-pushed the fix-osx-min-version branch from f53a494 to 5944f8a Compare May 28, 2023 13:56
@crazy-max
Copy link
Member Author

Haven't tried yet, but wondering if we need to update these two lines;

#cgo CFLAGS: -x objective-c -mmacosx-version-min=10.11
#cgo LDFLAGS: -framework Security -framework Foundation -mmacosx-version-min=10.11

I think we can keep 10.11 as minimum version looking at the current implementation of the keychain in our codebase.

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit 2860ca4 into docker:master May 28, 2023
@crazy-max crazy-max deleted the fix-osx-min-version branch May 28, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants