-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
osxkeychain: match min macos version for xx #283
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #283 +/- ##
=======================================
Coverage 55.23% 55.23%
=======================================
Files 9 9
Lines 668 668
=======================================
Hits 369 369
Misses 256 256
Partials 43 43
☔ View full report in Codecov by Sentry. |
Haven't tried yet, but wondering if we need to update these two lines; docker-credential-helpers/osxkeychain/osxkeychain_darwin.go Lines 4 to 5 in f8e94d9
|
abe5b9d
to
f53a494
Compare
Signed-off-by: CrazyMax <[email protected]>
f53a494
to
5944f8a
Compare
I think we can keep 10.11 as minimum version looking at the current implementation of the keychain in our codebase. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
partially solves #280
xx
sets a minimal macos version if not set throughMACOSX_VERSION_MIN
env var: https://github.com/tonistiigi/xx/blob/3d00d096c8bf894ec29bae5caa5aea81d9c187a5/base/xx-info#L203-L209