Adds packaging for Fedora 27 #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eli Uriegas <[email protected]>
thaJeztah
reviewed
Nov 14, 2017
| @@ -0,0 +1,17 @@ | |||
| FROM fedora:27 | |||
| RUN dnf -y upgrade | |||
| RUN dnf install -y @development-tools fedora-packager | |||
There was a problem hiding this comment.
Should we follow best-practice here, and combine dnf -y upgrade with the dnf install lines? (I guess we don't use caching, so probably doesn't make a big difference)
There was a problem hiding this comment.
Yeah these aren't cached when we build packages since we build on freshly spawned slaves in the Jenkins setup, WDYT @andrewhsu?
There was a problem hiding this comment.
It's just a nit, definitely no blocker for this PR
thaJeztah
approved these changes
Nov 14, 2017
|
Can confirm I was able to successfully build packages after the merge of docker-library/official-images#3708 |
|
Please also PR the docs when this is available. Would do it myself, but I don't know if F24 is still supported (and thus might need to be removed). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fedora 27 has hit GA! https://fedoramagazine.org/announcing-fedora-27/
Relies on: docker-library/official-images#3708
Relates to:
NOTE: The next release this is eligible for is
17.12.0-ceSigned-off-by: Eli Uriegas [email protected]