ci: restore builder.Makefile for docker-ce-packaging #9771
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compose gets rebuilt for `docker-ce-packaging` as part of DEB &
RPM builds. These cannot use Docker within the build, so need a
native `go build` command.
We want to keep this here so that we have control of the build
flags etc independently of packaging.
NOTE: The output path is now `bin/build/docker-compose` to keep
parity with the rest of the Compose build logic - previously
it was `bin/docker-compose` (no intermediate `build/` dir)
Signed-off-by: Milas Bowman <[email protected]>
milas
force-pushed
the
fix-docker-ce-packaging
branch
from
08d1432 to
1101cfb
Compare
nicksieger
approved these changes
Aug 19, 2022
|
Checked out and ran |
thaJeztah
added a commit
to thaJeztah/docker-ce-packaging
that referenced
this pull request
Aug 19, 2022
testing docker/compose#9771 Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added a commit
to thaJeztah/docker-ce-packaging
that referenced
this pull request
Aug 19, 2022
testing docker/compose#9771 Signed-off-by: Sebastiaan van Stijn <[email protected]> (cherry picked from commit 061b173) Signed-off-by: Sebastiaan van Stijn <[email protected]>
This was referenced Aug 19, 2022
|
We merged docker/docker-ce-packaging#744, which fixes the issue in packaging; I guess we can decide to keep that, or to switch back to using the Overall, the build for the compose plugin is fairly trivial, but of course the |
|
#9776 should obsolete this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Compose gets rebuilt for
docker-ce-packagingas part of DEB &RPM builds. These cannot use Docker within the build, so need a
native
go buildcommand.We want to keep this here so that we have control of the build
flags etc independently of packaging.
NOTE: The output path is now
bin/build/docker-composeto keepparity with the rest of the Compose build logic - previously
it was
bin/docker-compose(no intermediatebuild/dir)Related issue
docker/docker-ce-packaging#742
(not mandatory) A picture of a cute animal, if possible in relation with what you did
