-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better sandboxed workflow and enhanced cross compilation #9744
Conversation
Codecov Report
@@ Coverage Diff @@
## v2 #9744 +/- ##
=====================================
Coverage ? 14.47%
=====================================
Files ? 84
Lines ? 6846
Branches ? 0
=====================================
Hits ? 991
Misses ? 5747
Partials ? 108 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: CrazyMax <[email protected]>
Removed the step in ci that sends coverage report to Codecov (we can do that in a follow-up if you want) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work! Thank you so much @crazy-max
I'll update the checks when the PR will be merged into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing, very much appreciated! 🎉
This made it a PITA to build compose without docker (or more appropriately with a different build toolchain). Now I have to go through the dockerfile, figure out what ldfalgs are being set and other build arguments and pass that in manually to |
Awesome, thanks! |
This PR brings various improvements and fix some issues linked to non sandboxed builds.
builder.Makefile
has been removed as it's called anyway only within the Dockerfile.cross
target now effectively builds against any platforms (using--platform
with buildx) without hardcoded targets so we avoid building all platforms sequentially.Makefile
now calls bake to reduce commands overhead. I have not changed goals names in the Makefile to avoid disturbing your habits but would be nice to make things more generic likemake vendor
makes more sense thanmake go-mod-tidy
imo.docs
Dockerfile merged with main Dockerfile to avoid deduplicated stages for better cache reuse.scripts
folder not necessary anymore. Everything is handled inside the Dockerfile.This will also improve docker-ce-packaging for static bundles because atm
cross
target builds all platforms sequentially. cc @thaJeztah(not mandatory) A picture of a cute animal, if possible in relation with what you did
Signed-off-by: CrazyMax [email protected]