Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix network_mode "service:x" #8792

Merged
merged 1 commit into from
Oct 20, 2021

Conversation

ulyssessouza
Copy link
Collaborator

Related issue
Resolve #8766

(not mandatory) A picture of a cute animal, if possible in relation with what you did

Copy link
Member

@mat007 mat007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any test we can add? 😁

pkg/compose/convergence.go Show resolved Hide resolved
pkg/compose/convergence.go Outdated Show resolved Hide resolved
@ulyssessouza ulyssessouza force-pushed the fix-network-mode-service branch 2 times, most recently from 4da9062 to 3a7c2c2 Compare October 14, 2021 08:20
Signed-off-by: Ulysses Souza <[email protected]>
@ulyssessouza ulyssessouza force-pushed the fix-network-mode-service branch from 3a7c2c2 to c2dd40c Compare October 14, 2021 08:40
Copy link
Member

@mat007 mat007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to run service with network_mode "service:NAME"
2 participants