Fix compose down --timeout/-t flag #8788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Debdut Chakraborty <[email protected]>
Signed-off-by: Debdut Chakraborty <[email protected]>
|
PS: my backtick key isn't working. |
|
Hey Docker guys, Is there any way we can get this to production ASAP please? This PR seems to be working, all checks passing, it just requires review... LGTM, even though I'm not a Docker dev :P |
|
Wow that was super quick and appreciated, thanks @mat007 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Debdut Chakraborty [email protected]
What I did
Moved the PreRun stuff to PreRunE since only one hook is called. ${hook}E is preferred and thus previously cmd.Flags().Changed("timeout") never got a chance to run.
spf13/cobra#253
Related issue
Closes #8784
A picture of a cute animal