Make service>build>dockerfile a simple filename #8779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should still a draft until compose-spec/compose-go#195 gets merged |
ulyssessouza
force-pushed
the
build-dockerfile-relativepath
branch
from
f3999f9 to
3f9a3b2
Compare
ndeloof
requested changes
Oct 12, 2021
ndeloof
approved these changes
Oct 12, 2021
ulyssessouza
force-pushed
the
build-dockerfile-relativepath
branch
from
3f9a3b2 to
92720d7
Compare
mat007
approved these changes
Oct 14, 2021
thaJeztah
reviewed
Oct 14, 2021
ulyssessouza
force-pushed
the
build-dockerfile-relativepath
branch
4 times, most recently
from
e7ff923 to
1047c5b
Compare
Signed-off-by: Ulysses Souza <[email protected]>
- It makes it keep a simple filename instead of an absolute path Signed-off-by: Ulysses Souza <[email protected]>
ulyssessouza
force-pushed
the
build-dockerfile-relativepath
branch
from
1047c5b to
9437976
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8760
What I did
Related issue
(not mandatory) A picture of a cute animal, if possible in relation with what you did