-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add step in README to install on linux #8755
Conversation
README.md
Outdated
@@ -36,6 +36,7 @@ Or copy it into one of these folders for installing it system-wide: | |||
|
|||
* `/usr/local/lib/docker/cli-plugins` OR `/usr/local/libexec/docker/cli-plugins` | |||
* `/usr/lib/docker/cli-plugins` OR `/usr/libexec/docker/cli-plugins` | |||
* Rename the binary to `docker-compose` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the overall phrasing starting from Copy the relevant binary…
could be improved.
Maybe
Copy the relevant binary for your OS under `~/.docker/cli-plugins/docker-compose` or for installing it system-wide under one of:
- `/usr/local/lib/docker/cli-plugins/docker-compose` or `/usr/local/libexec/docker/cli-plugins/docker-compose`
- `/usr/lib/docker/cli-plugins/docker-compose` or `/usr/libexec/docker/cli-plugins/docker-compose`
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But do you think that Copy the relevant binary for your OS under ~/.docker/cli-plugins/docker-compose
should be ambiguous ? 🤔
Do you mean ~/.docker/cli-plugins/docker-compose/docker-compose-linux-x86_64
or realy create a new file named docker-compose
?
Of course this solution work and actualy I have no preferencies 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean
~/.docker/cli-plugins/docker-compose/docker-compose-linux-x86_64
or realy create a new file nameddocker-compose
?
It’s the latter.
Right, so maybe «Rename the relevant binary for your OS to docker-compose
and copy it to ~/.docker/cli-plugins
or …»?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alrigth, I committed your proposition.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Ah, the commits need to be DCO signed, see https://github.com/docker/compose/pull/8755/checks?check_run_id=3811804561 |
Signed-off-by: Yoann Bourdex <[email protected]>
Ok it's done |
Hello,
I followed the steps stupidly. In my case this one :
And I think there is a step missing : you must rename the binary to
docker-compose
.