-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore missing version commands #8738
Conversation
:+1, I didn't noticed we kept this one hidden, this was a mistake
I'm fine we introduce |
I think hiding this would be a nice idea, I'll add the change soon. |
All good for me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
045282d
to
e9a3c8b
Compare
…root command. Signed-off-by: Shikachuu <[email protected]>
e9a3c8b
to
b75ead0
Compare
Thanks for the reviews! |
What I did
version
command, since by default and for historical reasons aswell it shouldn't be hidden.--version
flag on the root command, I added it aswell.(This is up for a discuisson, since I think this change shouldn't be exist and we have to correct the documentation.)
(
If we are still planning to keep this change, I think it could be done more elegantly.I did it aswell, since I forgot that the old python version also handle the
-v
flag next to--version
)Related issue
Fix #8729
A picture of a cute animal, if possible in relation with what you did
(A hiding cat, reffering to the hidden version command.)