Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log --follow must stop when container get killed #8726

Merged
merged 1 commit into from
Oct 6, 2021

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Oct 1, 2021

What I did
compose logs --follow never complete if container gets killed
code missed running the logPrinter so it actually react on container events

#close #8715

(not mandatory) A picture of a cute animal, if possible in relation with what you did
image

@ndeloof ndeloof requested a review from ulyssessouza October 1, 2021 12:15
@ndeloof ndeloof force-pushed the log_follow_killed branch from d9cf22c to 4597f3e Compare October 1, 2021 12:24
@thaJeztah
Copy link
Member

hmf.. github is having issues (can't comment on the diff);

note that a kill event status doesn't necessarily means the container will exit (e.g. docker kill --signal=SIGHUP <container> also sends a kill event, but the container is still running

@ndeloof ndeloof force-pushed the log_follow_killed branch from 4597f3e to 4af04b2 Compare October 1, 2021 12:39
@ndeloof
Copy link
Contributor Author

ndeloof commented Oct 6, 2021

@ulyssessouza ?

Copy link
Collaborator

@ulyssessouza ulyssessouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@ulyssessouza ulyssessouza merged commit 0062703 into docker:v2 Oct 6, 2021
@ndeloof
Copy link
Contributor Author

ndeloof commented Oct 6, 2021

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression from v1.x: docker compose logs -f <containername> no longer exits when the container exits.
3 participants