Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for platform to composefile v3.7 too #5985

Closed

Conversation

vdemeester
Copy link

Bump composefile version to 3.7 too.

This is related to docker/cli#1050

That being said, I think one easy fix to that issue would be to add platform to v3 schema(s) — but it would start at schema 3.7and printing a warning when issuing a docker stack deploy that this field is not supported (same way we do it for build). It would allow to more easily updated from v2 to v3 for users and help us not make v2 and v3 schema diverge that much — at least not having elements in v2 that are not in v3…

Also linked to docker/cli#1081

Signed-off-by: Vincent Demeester [email protected]

@vdemeester vdemeester force-pushed the platform-on-compose-v3.7 branch from c03ab7d to bc877f1 Compare May 24, 2018 12:39
@vdemeester vdemeester changed the title Add support for platform to composefile v3 too Add support for platform to composefile v3.7 too May 24, 2018
@vdemeester
Copy link
Author

cc @shin- @dnephin

Copy link

@jetersen jetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far 👍

@bmayen
Copy link

bmayen commented Aug 26, 2018

Any plans to get this in soon?

@vdemeester
Copy link
Author

Closing this as it staled 😓

@vdemeester vdemeester closed this Feb 28, 2019
@chazt3n
Copy link

chazt3n commented Aug 2, 2019

did this happen or is platform still unavailable a year later?

@crossan007
Copy link

crossan007 commented Aug 29, 2019

I just tried it with Docker Engine 19.03.1, and a declared stack file version of 3.7:

version: "3.7"
services:
  vs_code:
    image: codercom/code-server
    pltatform: linux

result was not looking good:

> docker stack deploy --compose-file .\docker-compose.yml test1
platform Additional property pltaform is not allowed

@bmayen
Copy link

bmayen commented Aug 29, 2019

pltaform?

@crossan007
Copy link

Windows server 2019

@bmayen
Copy link

bmayen commented Aug 29, 2019

I was referring to the spelling 😉

@crossan007
Copy link

Ah you caught me 🙃

I did try it with correct spelling a few minutes after I posted this comment (hence the partial correction in the edit), still no dice.

@awakecoding
Copy link

Is this still planned? Looking at the latest comments, it looks like this PR got closed and 'platform' still isn't supported.

@jetersen
Copy link

@awakecoding I believe this will be solved with WSL 2 and updates to Windows Server 2019 as far as I recall.

@JoelKunze
Copy link

Can we reopen this? I could use support for platform in new compose format

@EricHripko
Copy link

Check out the upcoming 1.27.0 release of docker-compose. It merges v2 and v3 file formats and thereby brings back platform attribute.

@dazinator
Copy link

@awakecoding I believe this will be solved with WSL 2 and updates to Windows Server 2019 as far as I recall.

Is windows server 2019 getting WSL 2? I still have this issue on windows server 2019 vm that I just spun up on Azure.

@nicholasyin
Copy link

So how can I mix windows and linux containers in one docker compose file, as of today?

@convenient
Copy link

@nicholasyin use an up to date "docker-compose"

Not "docker compose".

#5985 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.